Skip to content

CCM-16449: Printing and postage errors #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-elliott-nhsd wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CCM-16449: Printing and postage errors #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5c9cb4
CCM-16449: Postage errors
chris-elliott-nhsd May 1, 2026
b928da4
CCM-16449: Fix linting
chris-elliott-nhsd May 1, 2026
c5a340f
CCM-16449: Fix tests
chris-elliott-nhsd May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions frontend/src/__tests__/app/preview-letter-template/__snapshots__/page.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5395,6 +5395,36 @@ exports[`valid authoring letter template displays the template saved banner when
type="hidden"
value=""
/>
<input
name="letterVariantId"
type="hidden"
value="variant-123"
/>
<input
name="letterVariantMaxSheets"
type="hidden"
value="5"
/>
<input
name="letterVariantBothSidesFlag"
type="hidden"
value="1"
/>
<input
name="templatePageCount"
type="hidden"
value="2"
/>
<input
name="shortRenderPageCount"
type="hidden"
value="0"
/>
<input
name="longRenderPageCount"
type="hidden"
value="0"
/>
<button
aria-disabled="false"
class="nhsuk-button"
Expand Down Expand Up @@ -6074,6 +6104,36 @@ exports[`valid authoring letter template matches snapshot 1`] = `
type="hidden"
value=""
/>
<input
name="letterVariantId"
type="hidden"
value="variant-123"
/>
<input
name="letterVariantMaxSheets"
type="hidden"
value="5"
/>
<input
name="letterVariantBothSidesFlag"
type="hidden"
value="1"
/>
<input
name="templatePageCount"
type="hidden"
value="2"
/>
<input
name="shortRenderPageCount"
type="hidden"
value="0"
/>
<input
name="longRenderPageCount"
type="hidden"
value="0"
/>
<button
aria-disabled="false"
class="nhsuk-button"
Expand Down
40 changes: 40 additions & 0 deletions frontend/src/__tests__/app/preview-letter-template/page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,46 @@ describe('valid authoring letter template', () => {

expect(screen.queryByRole('status')).not.toBeInTheDocument();
});

it('sets page count to 0 in hidden inputs when short/long renders are FAILED', async () => {
jest.mocked(getTemplate).mockResolvedValue({
...AUTHORING_LETTER_TEMPLATE,
files: {
...AUTHORING_LETTER_TEMPLATE.files,
shortFormRender: {
status: 'FAILED',
},
longFormRender: {
status: 'FAILED',
},
},
});

jest.mocked(getLetterVariantById).mockResolvedValue(
makeLetterVariant({
id: AUTHORING_LETTER_TEMPLATE.letterVariantId,
})
);

render(
await Page({
params: Promise.resolve({ templateId: AUTHORING_LETTER_TEMPLATE.id }),
})
);

const form = screen
.getByTestId('preview-letter-template-cta')
.closest('form')!;
const shortRenderPageCount = form.querySelector(
'input[name="shortRenderPageCount"]'
) as HTMLInputElement;
const longRenderPageCount = form.querySelector(
'input[name="longRenderPageCount"]'
) as HTMLInputElement;

expect(shortRenderPageCount.value).toBe('0');
expect(longRenderPageCount.value).toBe('0');
});
});

describe('authoring letter template with no letter variant set', () => {
Expand Down
Loading
Loading