CCM-16449: Printing and postage errors#928
Conversation
chris-elliott-nhsd
force-pushed
the
feature/CCM-15042_letter-gen-errors
branch
from
d622dd3 to
5e44446
Compare
chris-elliott-nhsd
force-pushed
the
feature/CCM-16449_postage-errors
branch
2 times, most recently
from
a43b691 to
d05da78
Compare
| } | ||
|
|
||
| if ( | ||
| Math.ceil(templatePageCount / (letterVariantBothSidesFlag ? 2 : 1)) > |
There was a problem hiding this comment.
since we also do this in PreviewTemplateDetailsAuthoringLetter.tsx, it might be worth a util
| actionText1: | ||
| 'reduce the number of sheets and upload a different letter template file', | ||
| actionText2: 'change your printing and postage option', | ||
| fieldText: 'Change your printing and postage option', |
There was a problem hiding this comment.
I think based on Michael's recent changes, you should be able to use the content renderer to do this, am I right @harrim91 ?
There was a problem hiding this comment.
It's possible to use markdown and ContentBlock to render things into the error summary component now - was in #907
There was a problem hiding this comment.
is there a good reason to use the content renderer instead of an error code for this? willing to do it, but it's a major rewrite so would prefer if there was a good reason for it. error codes have been in the codebase longer than the content renderer so feel like a reasonable pattern to follow
There was a problem hiding this comment.
another thought i had about this, because this error requires different content in the summary vs next to the form field, some kind of mapping is going to be required regardless of whether we use the content renderer, so you don't really gain much from passing markdown back from the form action that you then have to map to different markdown
chris-elliott-nhsd
force-pushed
the
feature/CCM-16449_postage-errors
branch
from
002b044 to
b5c9cb4
Compare
5 participants
Description
PR to implement feedback to users in the UI when there is a problem approving their template relating to their printing and postage settings
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.