Skip to content

add 2028 bank holidays #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshand merged 2 commits into from
Jan 5, 2026
+11 −1
Merged

add 2028 bank holidays #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb555e
add 2028 bank holidays
kenny-lee-1 Jan 5, 2026
f0e02ed
add 2028 bank holidays
bshand Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [Unreleased]
* no unreleased changes
## Fixed
* Add 2028 bank holidays

## 5.10.5 / 2025-11-05
## Fixed
Expand Down
9 changes: 9 additions & 0 deletions lib/ndr_support/concerns/working_days.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,15 @@ module WorkingDays # rubocop:disable Metrics/ModuleLength
'2027-08-30', # Monday - Summer bank holiday
'2027-12-27', # Monday - Christmas Day
'2027-12-28', # Tuesday - Boxing Day
# 2028
'2028-01-03', # Monday - New Year’s Day (Substitute day)
'2028-04-14', # Friday - Good Friday
'2028-04-17', # Monday - Easter Monday
'2028-05-01', # Monday - Early May bank holiday
'2028-05-29', # Monday - Spring bank holiday
'2028-08-28', # Monday - Summer bank holiday
'2028-12-25', # Monday - Christmas Day
'2028-12-26' # Tuesday - Boxing Day
].map { |str| Date.parse(str) }
# rubocop:enable Style/TrailingCommaInArrayLiteral

Expand Down