Skip to content

add 2028 bank holidays #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bshand merged 2 commits into from
Jan 5, 2026
Merged

add 2028 bank holidays #62

bshand merged 2 commits into from
Jan 5, 2026
+11 −1

Conversation

@kenny-lee-1
Copy link
Contributor

@kenny-lee-1 kenny-lee-1 commented Jan 5, 2026

This PR

  • adds 2028 bank holidays
  • should stop a test failing which is checking the gov.uk API for future bank holiday dates

bshand
bshand approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@bshand bshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've also added a CHANGELOG entry.

@bshand bshand merged commit f4c6f36 into main Jan 5, 2026
12 checks passed
@bshand bshand deleted the feature/2028_bank_holidays branch January 5, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshand bshand bshand approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenny-lee-1 @bshand