Skip to content

Fix/blood pressure slicing error #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryma2fhir wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix/blood pressure slicing error #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bacca6
removed loinc values
ryma2fhir Nov 5, 2025
c0c6952
removed component.code slice
ryma2fhir Nov 5, 2025
ebb3797
removed custom component.code description as no extra information added
ryma2fhir Nov 5, 2025
2f64c26
removed all loinc codes from Observation.code.coding and moved the sn…
ryma2fhir Nov 6, 2025
a7510ba
removed left over slicing that Forge did not remove. updated version …
ryma2fhir Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 5 additions & 23 deletions structuredefinitions/UKCore-Observation-VitalSigns-BMI.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<StructureDefinition xmlns="http://hl7.org/fhir">
<id value="UKCore-Observation-VitalSigns-BMI" />
<url value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns-BMI" />
<version value="1.0.0" />
<version value="0.1.1" />
<name value="UKCoreObservationVitalSignsBMI" />
<title value="UK Core Observation Vital Signs BMI" />
<status value="active" />
<date value="2024-07-11" />
<status value="draft" />
<date value="2025-11-06" />
<publisher value="HL7 UK" />
<contact>
<name value="HL7 UK" />
Expand All @@ -27,31 +27,13 @@
<baseDefinition value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns" />
<derivation value="constraint" />
<differential>
<element id="Observation.code.coding:loinc">
<path value="Observation.code.coding" />
<sliceName value="loinc" />
</element>
<element id="Observation.code.coding:loinc.code">
<path value="Observation.code.coding.code" />
<fixedCode value="39156-5" />
</element>
<element id="Observation.code.coding:snomedCT">
<path value="Observation.code.coding" />
<sliceName value="snomedCT" />
<max value="1" />
<element id="Observation.code">
<path value="Observation.code" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BMI" />
</binding>
</element>
<element id="Observation.code.coding:snomedCT.system">
<path value="Observation.code.coding.system" />
<min value="1" />
</element>
<element id="Observation.code.coding:snomedCT.code">
<path value="Observation.code.coding.code" />
<min value="1" />
</element>
<element id="Observation.value[x]">
<path value="Observation.value[x]" />
<min value="1" />
Expand Down
133 changes: 9 additions & 124 deletions structuredefinitions/UKCore-Observation-VitalSigns-BloodPressure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<StructureDefinition xmlns="http://hl7.org/fhir">
<id value="UKCore-Observation-VitalSigns-BloodPressure" />
<url value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns-BloodPressure" />
<version value="1.0.0" />
<version value="0.1.1" />
<name value="UKCoreObservationVitalSignsBloodPressure" />
<title value="UK Core Observation Vital Signs Blood Pressure" />
<status value="active" />
<date value="2023-09-12" />
<status value="draft" />
<date value="2025-11-06" />
<publisher value="HL7 UK" />
<contact>
<name value="HL7 UK" />
Expand All @@ -27,17 +27,8 @@
<baseDefinition value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns" />
<derivation value="constraint" />
<differential>
<element id="Observation.code.coding:loinc">
<path value="Observation.code.coding" />
<sliceName value="loinc" />
</element>
<element id="Observation.code.coding:loinc.code">
<path value="Observation.code.coding.code" />
<fixedCode value="85354-9" />
</element>
<element id="Observation.code.coding:snomedCT">
<path value="Observation.code.coding" />
<sliceName value="snomedCT" />
<element id="Observation.code">
<path value="Observation.code" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BloodPressure" />
Expand Down Expand Up @@ -78,95 +69,19 @@
<min value="1" />
<max value="2" />
</element>
<element id="Observation.component.code">
<path value="Observation.component.code" />
<binding>
<strength value="preferred" />
<description value="A code from the SNOMED Clinical Terminology UK coding system describing a type of vital sign." />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-ObservationVitalSignsType" />
</binding>
</element>
<element id="Observation.component.code.coding">
<path value="Observation.component.code.coding" />
<slicing>
<discriminator>
<type value="value" />
<path value="system" />
</discriminator>
<rules value="open" />
</slicing>
</element>
<element id="Observation.component.code.coding:loinc">
<path value="Observation.component.code.coding" />
<sliceName value="loinc" />
<min value="1" />
<max value="1" />
<binding>
<strength value="extensible" />
<valueSet value="http://hl7.org/fhir/ValueSet/observation-vitalsignresult" />
</binding>
</element>
<element id="Observation.component.code.coding:loinc.system">
<path value="Observation.component.code.coding.system" />
<fixedUri value="http://loinc.org" />
</element>
<element id="Observation.component.code.coding:snomedCT">
<path value="Observation.component.code.coding" />
<sliceName value="snomedCT" />
<min value="1" />
<binding>
<strength value="preferred" />
<description value="A code from the SNOMED Clinical Terminology UK coding system describing a type of observation for vital-signs" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-ObservationVitalSignsType" />
</binding>
</element>
<element id="Observation.component.code.coding:snomedCT.system">
<path value="Observation.component.code.coding.system" />
<fixedUri value="http://snomed.info/sct" />
</element>
<element id="Observation.component:SystolicBP">
<path value="Observation.component" />
<sliceName value="SystolicBP" />
<min value="1" />
<max value="1" />
</element>
<element id="Observation.component:SystolicBP.code.coding">
<path value="Observation.component.code.coding" />
<slicing>
<discriminator>
<type value="value" />
<path value="system" />
</discriminator>
<rules value="open" />
</slicing>
</element>
<element id="Observation.component:SystolicBP.code.coding:loinc">
<path value="Observation.component.code.coding" />
<sliceName value="loinc" />
<min value="1" />
<max value="1" />
</element>
<element id="Observation.component:SystolicBP.code.coding:loinc.code">
<path value="Observation.component.code.coding.code" />
<fixedCode value="8480-6" />
</element>
<element id="Observation.component:SystolicBP.code.coding:loinc.display">
<path value="Observation.component.code.coding.display" />
<fixedString value="Systolic blood pressure" />
</element>
<element id="Observation.component:SystolicBP.code.coding:snomedCT">
<path value="Observation.component.code.coding" />
<sliceName value="snomedCT" />
<min value="1" />
<element id="Observation.component:SystolicBP.code">
<path value="Observation.component.code" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BloodPressure-Systolic" />
</binding>
</element>
<element id="Observation.component:SystolicBP.code.text">
<path value="Observation.component.code.text" />
<fixedString value="Systolic blood pressure" />
</element>
<element id="Observation.component:SystolicBP.value[x]">
<path value="Observation.component.value[x]" />
<min value="1" />
Expand All @@ -191,43 +106,13 @@
<sliceName value="DiastolicBP" />
<max value="1" />
</element>
<element id="Observation.component:DiastolicBP.code.coding">
<path value="Observation.component.code.coding" />
<slicing>
<discriminator>
<type value="value" />
<path value="system" />
</discriminator>
<rules value="open" />
</slicing>
</element>
<element id="Observation.component:DiastolicBP.code.coding:loinc">
<path value="Observation.component.code.coding" />
<sliceName value="loinc" />
<min value="1" />
<max value="1" />
</element>
<element id="Observation.component:DiastolicBP.code.coding:loinc.code">
<path value="Observation.component.code.coding.code" />
<fixedCode value="8462-4" />
</element>
<element id="Observation.component:DiastolicBP.code.coding:loinc.display">
<path value="Observation.component.code.coding.display" />
<fixedString value="Diastolic blood pressure" />
</element>
<element id="Observation.component:DiastolicBP.code.coding:snomedCT">
<path value="Observation.component.code.coding" />
<sliceName value="snomedCT" />
<min value="1" />
<element id="Observation.component:DiastolicBP.code">
<path value="Observation.component.code" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BloodPressure-Diastolic" />
</binding>
</element>
<element id="Observation.component:DiastolicBP.code.text">
<path value="Observation.component.code.text" />
<fixedString value="Diastolic blood pressure" />
</element>
<element id="Observation.component:DiastolicBP.value[x]">
<path value="Observation.component.value[x]" />
<min value="1" />
Expand Down
22 changes: 6 additions & 16 deletions structuredefinitions/UKCore-Observation-VitalSigns-BodyHeight.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<StructureDefinition xmlns="http://hl7.org/fhir">
<id value="UKCore-Observation-VitalSigns-BodyHeight" />
<url value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns-BodyHeight" />
<version value="1.1.1" />
<version value="0.1.1" />
<name value="UKCoreObservationVitalSignsBodyHeight" />
<title value="UK Core Observation Vital Signs Body Height" />
<status value="active" />
<date value="2025-03-11" />
<status value="draft" />
<date value="2025-11-06" />
<publisher value="HL7 UK" />
<contact>
<name value="HL7 UK" />
Expand All @@ -27,20 +27,10 @@
<baseDefinition value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns" />
<derivation value="constraint" />
<differential>
<element id="Observation.code.coding:loinc">
<path value="Observation.code.coding" />
<sliceName value="loinc" />
</element>
<element id="Observation.code.coding:loinc.code">
<path value="Observation.code.coding.code" />
<fixedCode value="8302-2" />
</element>
<element id="Observation.code.coding:snomedCT">
<path value="Observation.code.coding" />
<sliceName value="snomedCT" />
<element id="Observation.code">
<path value="Observation.code" />
<binding>
<strength value="preferred" />
<description value="A code from the SNOMED CT UK coding system for length measurements." />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BodyHeightMeasurements" />
</binding>
</element>
Expand All @@ -57,4 +47,4 @@
</binding>
</element>
</differential>
</StructureDefinition>
</StructureDefinition>
28 changes: 5 additions & 23 deletions structuredefinitions/UKCore-Observation-VitalSigns-BodyTemperature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<StructureDefinition xmlns="http://hl7.org/fhir">
<id value="UKCore-Observation-VitalSigns-BodyTemperature" />
<url value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns-BodyTemperature" />
<version value="1.0.0" />
<version value="0.1.1" />
<name value="UKCoreObservationVitalSignsBodyTemperature" />
<title value="UK Core Observation Vital Signs Body Temperature" />
<status value="active" />
<date value="2023-09-12" />
<status value="draft" />
<date value="2025-11-06" />
<publisher value="HL7 UK" />
<contact>
<name value="HL7 UK" />
Expand All @@ -27,31 +27,13 @@
<baseDefinition value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns" />
<derivation value="constraint" />
<differential>
<element id="Observation.code.coding:loinc">
<path value="Observation.code.coding" />
<sliceName value="loinc" />
</element>
<element id="Observation.code.coding:loinc.code">
<path value="Observation.code.coding.code" />
<fixedCode value="8310-5" />
</element>
<element id="Observation.code.coding:snomedCT">
<path value="Observation.code.coding" />
<sliceName value="snomedCT" />
<max value="1" />
<element id="Observation.code">
<path value="Observation.code" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BodyTemperature" />
</binding>
</element>
<element id="Observation.code.coding:snomedCT.system">
<path value="Observation.code.coding.system" />
<min value="1" />
</element>
<element id="Observation.code.coding:snomedCT.code">
<path value="Observation.code.coding.code" />
<min value="1" />
</element>
<element id="Observation.value[x]">
<path value="Observation.value[x]" />
<min value="1" />
Expand Down
22 changes: 6 additions & 16 deletions structuredefinitions/UKCore-Observation-VitalSigns-BodyWeight.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<StructureDefinition xmlns="http://hl7.org/fhir">
<id value="UKCore-Observation-VitalSigns-BodyWeight" />
<url value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns-BodyWeight" />
<version value="1.0.0" />
<version value="0.1.1" />
<name value="UKCoreObservationVitalSignsBodyWeight" />
<title value="UK Core Observation Vital Signs Body Weight" />
<status value="active" />
<date value="2023-09-12" />
<status value="draft" />
<date value="2025-11-06" />
<publisher value="HL7 UK" />
<contact>
<name value="HL7 UK" />
Expand All @@ -27,20 +27,10 @@
<baseDefinition value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns" />
<derivation value="constraint" />
<differential>
<element id="Observation.code.coding:loinc">
<path value="Observation.code.coding" />
<sliceName value="loinc" />
</element>
<element id="Observation.code.coding:loinc.code">
<path value="Observation.code.coding.code" />
<fixedCode value="29463-7" />
</element>
<element id="Observation.code.coding:snomedCT">
<path value="Observation.code.coding" />
<sliceName value="snomedCT" />
<element id="Observation.code">
<path value="Observation.code" />
<binding>
<strength value="preferred" />
<description value="A code from the SNOMED CT UK coding system for weight measurements." />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BodyWeightMeasurements" />
</binding>
</element>
Expand All @@ -64,4 +54,4 @@
<fixedCode value="kg" />
</element>
</differential>
</StructureDefinition>
</StructureDefinition>
Loading