Fix/blood pressure slicing error #698
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Noticed that it breaks all other vitalsigns profiles. I'll remedy this tomorrow. |
…omedCT ValuseSets to code. Kept as preferred. All coding.system and coding.code cardinalities reverted back from 1..1 to 0..1 (default)
…and date, set status to draft as these have not been through ballot and still work in progress
jadedavies11
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
component.codeslicing was causing validation errors onObserationVitalSigns-BloodPressure. This is due to slicing names being the same across 3 slices (loinc & snomedCT).The fix could either be to rename each to ensure uniqueness, but loinc was added on the assumption that it had to be present due to other vitalsigns profiles within international FHIR. This profile is based off UK Core Observation and makes no such claims it conforms to HL7 International profiles. With LOINC not being used in UK, this is adding necessary complexity to the profiles with no benefit.
I propose we remove the LOINC constraints across all vitalsigns profiles. With a customer struggling with validation with this profile I'll do this first.
Changes made
Observation-VitalSigns.code.codingSNOMED CT slice removed and valueset moved to the elementObservation-VitalSigns.component.code.codingSNOMED CT slice removed valueset moved to the relevant systolic and diastolic slices. Open slice reverted to base profile