-
Notifications
You must be signed in to change notification settings - Fork 144
[CLEANUP] Order class names in the class diagram alphabetically #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+52
−52
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -624,106 +624,106 @@ classDiagram | |
|
||
%% Start of the part originally generated from the PHP code using tasuku43/mermaid-class-diagram | ||
|
||
class CSSElement { | ||
<<interface>> | ||
class Anchor { | ||
} | ||
class Renderable { | ||
class AtRule { | ||
<<interface>> | ||
} | ||
class Positionable { | ||
<<interface>> | ||
class AtRuleBlockList { | ||
} | ||
class CSSListItem { | ||
<<interface>> | ||
class AtRuleSet { | ||
} | ||
class RuleContainer { | ||
class CSSBlockList { | ||
<<abstract>> | ||
} | ||
class CSSElement { | ||
<<interface>> | ||
} | ||
class DeclarationBlock { | ||
class CSSFunction { | ||
} | ||
class RuleSet { | ||
class CSSList { | ||
<<abstract>> | ||
} | ||
class AtRuleSet { | ||
class CSSListItem { | ||
<<interface>> | ||
} | ||
class KeyframeSelector { | ||
class CSSNamespace { | ||
} | ||
class AtRule { | ||
<<interface>> | ||
class CSSString { | ||
} | ||
class CalcFunction { | ||
} | ||
Comment on lines
+652
to
+655
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In my alphabet, 'a' comes before 's'. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The diagram generator we're using seems to sort an uppercase "S" before a lowercase "a", it seems. |
||
class CalcRuleValueList { | ||
} | ||
class Charset { | ||
} | ||
class Import { | ||
class Color { | ||
} | ||
class Selector { | ||
class Comment { | ||
} | ||
class CSSNamespace { | ||
class Commentable { | ||
<<interface>> | ||
} | ||
class Settings { | ||
class DeclarationBlock { | ||
} | ||
class Rule { | ||
class Document { | ||
} | ||
class Parser { | ||
class Import { | ||
} | ||
class OutputFormatter { | ||
class KeyFrame { | ||
} | ||
class OutputFormat { | ||
class KeyframeSelector { | ||
} | ||
class LineName { | ||
} | ||
class OutputException { | ||
} | ||
class UnexpectedEOFException { | ||
class OutputFormat { | ||
} | ||
class SourceException { | ||
class OutputFormatter { | ||
} | ||
class UnexpectedTokenException { | ||
class Parser { | ||
} | ||
class ParserState { | ||
} | ||
class Anchor { | ||
} | ||
class CSSBlockList { | ||
<<abstract>> | ||
} | ||
class Document { | ||
class Positionable { | ||
<<interface>> | ||
} | ||
class CSSList { | ||
class PrimitiveValue { | ||
<<abstract>> | ||
} | ||
class KeyFrame { | ||
} | ||
class AtRuleBlockList { | ||
} | ||
class Color { | ||
class Renderable { | ||
<<interface>> | ||
} | ||
class URL { | ||
class Rule { | ||
} | ||
class CalcRuleValueList { | ||
class RuleContainer { | ||
<<interface>> | ||
} | ||
class ValueList { | ||
class RuleSet { | ||
<<abstract>> | ||
} | ||
class CalcFunction { | ||
class RuleValueList { | ||
} | ||
class LineName { | ||
class Selector { | ||
} | ||
class Value { | ||
<<abstract>> | ||
class Settings { | ||
} | ||
class Size { | ||
} | ||
class CSSString { | ||
class SourceException { | ||
} | ||
class PrimitiveValue { | ||
<<abstract>> | ||
class UnexpectedEOFException { | ||
} | ||
class CSSFunction { | ||
class UnexpectedTokenException { | ||
} | ||
class RuleValueList { | ||
class URL { | ||
} | ||
class Commentable { | ||
<<interface>> | ||
class Value { | ||
<<abstract>> | ||
} | ||
class Comment { | ||
class ValueList { | ||
<<abstract>> | ||
} | ||
|
||
RuleSet <|-- DeclarationBlock: inheritance | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer the blank line between the settings and the content to be retained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.