Skip to content

[CLEANUP] Order class names in the class diagram alphabetically #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 52 additions & 52 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -624,106 +624,106 @@ classDiagram

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the blank line between the settings and the content to be retained.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

%% Start of the part originally generated from the PHP code using tasuku43/mermaid-class-diagram

class CSSElement {
<<interface>>
class Anchor {
}
class Renderable {
class AtRule {
<<interface>>
}
class Positionable {
<<interface>>
class AtRuleBlockList {
}
class CSSListItem {
<<interface>>
class AtRuleSet {
}
class RuleContainer {
class CSSBlockList {
<<abstract>>
}
class CSSElement {
<<interface>>
}
class DeclarationBlock {
class CSSFunction {
}
class RuleSet {
class CSSList {
<<abstract>>
}
class AtRuleSet {
class CSSListItem {
<<interface>>
}
class KeyframeSelector {
class CSSNamespace {
}
class AtRule {
<<interface>>
class CSSString {
}
class CalcFunction {
}
Comment on lines +652 to +655
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my alphabet, 'a' comes before 's'.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagram generator we're using seems to sort an uppercase "S" before a lowercase "a", it seems.

class CalcRuleValueList {
}
class Charset {
}
class Import {
class Color {
}
class Selector {
class Comment {
}
class CSSNamespace {
class Commentable {
<<interface>>
}
class Settings {
class DeclarationBlock {
}
class Rule {
class Document {
}
class Parser {
class Import {
}
class OutputFormatter {
class KeyFrame {
}
class OutputFormat {
class KeyframeSelector {
}
class LineName {
}
class OutputException {
}
class UnexpectedEOFException {
class OutputFormat {
}
class SourceException {
class OutputFormatter {
}
class UnexpectedTokenException {
class Parser {
}
class ParserState {
}
class Anchor {
}
class CSSBlockList {
<<abstract>>
}
class Document {
class Positionable {
<<interface>>
}
class CSSList {
class PrimitiveValue {
<<abstract>>
}
class KeyFrame {
}
class AtRuleBlockList {
}
class Color {
class Renderable {
<<interface>>
}
class URL {
class Rule {
}
class CalcRuleValueList {
class RuleContainer {
<<interface>>
}
class ValueList {
class RuleSet {
<<abstract>>
}
class CalcFunction {
class RuleValueList {
}
class LineName {
class Selector {
}
class Value {
<<abstract>>
class Settings {
}
class Size {
}
class CSSString {
class SourceException {
}
class PrimitiveValue {
<<abstract>>
class UnexpectedEOFException {
}
class CSSFunction {
class UnexpectedTokenException {
}
class RuleValueList {
class URL {
}
class Commentable {
<<interface>>
class Value {
<<abstract>>
}
class Comment {
class ValueList {
<<abstract>>
}

RuleSet <|-- DeclarationBlock: inheritance
Expand Down