[CLEANUP] Order class names in the class diagram alphabetically #1299
Conversation
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
added
documentation
cleanup
developer-specific
oliverklee
force-pushed
the
cleanup/reorder-classes
branch
from
819128d to
601cb8b
Compare
There was a problem hiding this comment.
I'm not entirely sure of the rationale behind the reordering, but since there was no specific order prevoiusly (other than to try and get the class diagram to render more clearly, which didn't work), it's fine.
However, I think lexicographical ordering would be better than ASCII, and the blank line after the config settings should be kept.
| @@ -621,109 +621,108 @@ class Sabberworm\CSS\CSSList\Document#4 (2) { | |||
| ```mermaid | |||
| classDiagram | |||
| direction LR | |||
|
|
|||
There was a problem hiding this comment.
I'd prefer the blank line between the settings and the content to be retained.
| class CSSString { | ||
| } | ||
| class CalcFunction { | ||
| } |
There was a problem hiding this comment.
In my alphabet, 'a' comes before 's'.
There was a problem hiding this comment.
The diagram generator we're using seems to sort an uppercase "S" before a lowercase "a", it seems.
oliverklee
force-pushed
the
cleanup/reorder-classes
branch
from
601cb8b to
4761d46
Compare
The rationale is to make the diff smaller in the PR that uses the updated autogenerated class diagram. |
There was a problem hiding this comment.
The rationale is to make the diff smaller in the PR that uses the updated autogenerated class diagram.
The diagram generator we're using seems to sort an uppercase "S" before a lowercase "a", it seems.
I understand now. Thanks.
No description provided.