Make PyPI Release #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also try to see if actions still pass after a year of inactivity
- probable reason: scikit-learn is not a dependency in requirments_dev.txt - TSNE default probably have changed?
- instead of requirements_dev.txt and see if then the results for TSNE reproduce.
- results depends on chip architecture!!! (not good)
- local error that env had to be defined by hand - local package alwasy included if not specified otherwise? follow latest tox guide: https://tox.wiki/en/4.18.0/user_guide.html
- behaviour in GitHub action is different from local tox run, which runs all envs in envlist
Upload was blocked for an RST reason - used "twine check" to identify the bug -> project.toml update was not needed, but is still valuable for long-term support
- github release tags a commit, but the action is triggered only by the publishing event of a release
|
It will require multiple iterations, but it is great to have make it available in PyPi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release will be done through an action which is triggered by a GitHub release event.