Skip to content

set trailing slash optional in route matching #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions api/tests/test-router.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,30 @@ o.spec("route", function() {
)
})

o("remove trailing slash to match route if it is before rest operator match (...) ", function() {
$window.location.href = prefix + "/test/d/"
route(root, "/test/some/path", {
"/test/:a" : {
view: lock(function(vnode) {
return JSON.stringify(route.param()) + " " +
JSON.stringify(vnode.attrs) + " " +
route.get()
})
},
"/test/:a..." : {
view: lock(function(vnode) {
return JSON.stringify(route.param()) + " " +
JSON.stringify(vnode.attrs) + " " +
route.get()
})
},
})

o(root.firstChild.nodeValue).equals(
'{"a":"d"} {"a":"d"} /test/d/'
)
})

o("handles route with search", function() {
$window.location.href = prefix + "/test?a=b&c=d"
route(root, "/test", {
Expand Down
2 changes: 1 addition & 1 deletion pathname/compileTemplate.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = function(template) {
if (extra === ".") return "([^/]+)\\."
return "([^/]+)" + (extra || "")
}
) + "$")
) + "\\/?$")
return function(data) {
// First, check the params. Usually, there isn't any, and it's just
// checking a static set.
Expand Down