Skip to content

set trailing slash optional in route matching #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

touletan
Copy link

@touletan touletan commented May 23, 2025

Description

Regexp has been updated to set trailing slash as optional in route matching.

Motivation and Context

link to issue 3024.

How Has This Been Tested?

New test has been added. The previous change to keep trailing slash when it match with rest operator is still working.
This is removing the previoous breaking change of always keeping the trailing slash.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires a documentation update, and I've opened a pull request to update it already:
  • I have read https://mithril.js.org/contributing.html.

@touletan touletan requested a review from a team as a code owner May 23, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant