feat: multisrp ui #29816

montelaidev · 2025-01-21T08:03:59Z

Description

This PR introduces multisrp to the UI. It enables the importing of a SRP, creating accounts associated to a SRP and revealing the associated SRP.

Related issues

Depends on #29942

Manual testing steps

Importing a new SRP

Click on the account selector
Click on connect more
Click on Import secret recovery phrase
Paste in a SRP
Continue
See a new account is created
Click on the account selector and see new pills indicating the SRP numbers

Creating an account for a specific SRP

Import a new SRP
Click on add new account
Select the SRP you want to create the account to.
See a new account is created

Revealing SRP

Import a new SRP
Click on the account menu
Go to settings --> security and privacy
Click on reveal srp
Select the srp that you want to reveal
Go through SRP quiz and click. to reveal
See the SRP

Screenshots/Recordings

After

Importing a new SRP

Screen.Recording.2025-02-14.at.17.26.32.mov

Creating accounts associated to an srp

Screen.Recording.2025-02-14.at.17.26.53.mov

Revealing SRPs

Screen.Recording.2025-02-14.at.17.26.32.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…instead of preferencesController

… balance

Co-authored-by: Monte Lai <[email protected]>

…instead of preferencesController

… balance

Co-authored-by: Monte Lai <[email protected]>

ui/components/multichain/account-details/account-details-display.js

ui/components/multichain/account-details/account-details.tsx

ui/components/multichain/account-list-menu/account-list-menu.tsx

ui/components/multichain/multi-srp/srp-list/srp-list.tsx

ui/pages/settings/security-tab/security-tab.container.js

ui/selectors/selectors.js

ui/store/actions.ts

danroc · 2025-02-26T12:44:04Z

Is this part of the design? It's strange to say that a SRP can also be 15, 18, or 21 words but the only options are 12 or 24.

montelaidev · 2025-02-26T13:37:30Z

Is this part of the design? It's strange to say that a SRP can also be 15, 18, or 21 words but the only options are 12 or 24.

Updated this on 4418a35

test/e2e/flask/multi-srp/add-accounts.spec.ts

ui/helpers/utils/util.js

aganglada · 2025-02-25T15:22:09Z

ui/components/multichain/create-account/create-account.tsx

+              <Box marginBottom={3}>
+                <SelectSRP
+                  onClick={onSelectSRP}
+                  srpName={`Secret Phrase ${selectedKeyringIndex + 1}`}


Need a transalated message here

aganglada · 2025-02-26T15:05:31Z

app/scripts/metamask-controller.js

@@ -4331,7 +4331,11 @@ export default class MetamaskController extends EventEmitter {
      this.accountsController.setSelectedAccount(account.id);

      // TODO: Find a way to encapsulate this logic in the KeyringController itself.
-      const keyringId = findKeyringIdByAddress(newAccountAddress);
+      const { keyrings, keyringsMetadata } = this.keyringController.state;
+      const keyringId = findKeyringId(keyrings, keyringsMetadata, {


isnt findKeyringId going to fail if not included on the code fence?

No, the keyring controller will have the KeyringMetadata.

but the import of findKeyringId is fenced

The importMnemonicToVault using findKeyringId is also fenced.

aganglada · 2025-02-26T15:09:00Z

ui/components/app/toast-master/utils.ts

+
+export function setShowNewSRPAddedToast(value: boolean) {
+  return {
+    type: SET_SHOW_NEW_SRP_ADDED_TOAST,
+    payload: value,
+  };
+}


missing code-fence?

aganglada · 2025-02-26T15:13:27Z

ui/components/multichain/index.js

@@ -51,3 +51,4 @@ export { ReceiveModal } from './receive-modal';
 export { EditNetworksModal } from './edit-networks-modal';
 export { EditAccountsModal } from './edit-accounts-modal';
 export { Carousel } from './carousel';
+export { ImportSRP, SelectSRP, SRPList } from './multi-srp';


we should probably code fence here

aganglada · 2025-02-26T15:15:17Z

ui/components/multichain/multi-srp/import-srp/import-srp.tsx

+      let newSrpError = '';
+      const joinedDraftSrp = newDraftSrp.join(' ').trim();
+      let invalidWords = Array(newDraftSrp.length).fill(false);
+
+      if (newDraftSrp.some((word) => word !== '')) {
+        invalidWords = newDraftSrp.map((word) => !wordlist.includes(word));
+
+        if (newDraftSrp.some((word) => word === '')) {
+          newSrpError = t('importSRPNumberOfWordsError');
+        } else if (hasUpperCase(joinedDraftSrp)) {
+          newSrpError = t('invalidSeedPhraseCaseSensitive');
+        } else if (invalidWords.some((word) => word === true)) {
+          const invalidWordIndex = invalidWords.reduce((acc, word, index) => {
+            if (word) {
+              // We add 1 to the index because the index is 0-based
+              // This is displayed to the user to show which word in the list is incorrect.
+              acc.push(index + 1);
+            }
+            return acc;
+          }, []);
+          if (invalidWordIndex.length === 1) {
+            newSrpError = t('importSRPWordError', [invalidWordIndex.pop()]);
+          } else if (invalidWordIndex.length >= 2) {
+            const firstPartOfError = invalidWordIndex.slice(0, -1).join(', ');
+            newSrpError = t('importSRPWordErrorAlternative', [
+              firstPartOfError,
+              invalidWordIndex.pop(),
+            ]);
+          }
+        } else if (!isValidMnemonic(joinedDraftSrp)) {
+          newSrpError = t('invalidSeedPhrase');
+        }
+      }


we should probably move this somewhere and make it a bit more readable

aganglada · 2025-02-26T15:16:45Z

ui/components/multichain/multichain-components.scss

@@ -47,3 +47,4 @@
 @import 'notifications-tag-counter';
 @import 'toast';
 @import "ramps-card";
+@import "multi-srp";


can this be code fenced?

metamaskbot · 2025-02-26T15:29:17Z

Builds ready [945c285]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1794 ± 104 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1475	2443	1794	227	109
		domContentLoaded	1464	2366	1766	216	104
		load	1477	2373	1794	217	104
		domInteractive	26	115	40	25	12
		backgroundConnect	11	74	29	20	10
		firstReactRender	15	81	32	23	11
		getState	5	63	21	20	10
		initialActions	0	1	0	0	0
		loadScripts	1084	1882	1327	189	91
		setupStore	7	62	24	21	10
		uiStartup	1708	2690	2056	237	114

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 18.16 KiB (0.24%)
common: 1.78 KiB (0.02%)

ccharly · 2025-02-26T15:05:24Z

ui/pages/settings/security-tab/reveal-srp-list/reveal-srp-list.tsx

@@ -0,0 +1,28 @@
+import React, { useState } from 'react';
+import { Box } from '../../../../components/component-library';
+import SRPQuizModal from '../../../../components/app/srp-quiz-modal/SRPQuiz';


Filename looks wrong now. Looking at other modals, it probably should be:
components/app/srp-quiz-modal/srp-quiz-modal.tsx

ccharly · 2025-02-26T15:06:53Z

ui/pages/settings/security-tab/security-tab.container.js

@@ -77,6 +87,10 @@ const mapStateToProps = (state) => {
    securityAlertsEnabled: getIsSecurityAlertsEnabled(state),
    useTransactionSimulations: metamask.useTransactionSimulations,
    metaMetricsDataDeletionId: getMetaMetricsDataDeletionId(state),
+    ///: BEGIN:ONLY_INCLUDE_IF(multi-srp)
+    selectedAccount: getSelectedInternalAccount(state),


Do we need this? I don't see it being declared on ui/pages/settings/security-tab/security-tab.component.js props?

ccharly · 2025-02-26T15:08:21Z

ui/pages/settings/security-tab/security-tab.container.js

@@ -77,6 +87,10 @@ const mapStateToProps = (state) => {
    securityAlertsEnabled: getIsSecurityAlertsEnabled(state),
    useTransactionSimulations: metamask.useTransactionSimulations,
    metaMetricsDataDeletionId: getMetaMetricsDataDeletionId(state),
+    ///: BEGIN:ONLY_INCLUDE_IF(multi-srp)
+    selectedAccount: getSelectedInternalAccount(state),
+    hasMultipleHDKeyrings,


Nit: Minor, but other "HD" names, uses "Hd" (not a real issue, but just wanted to note that)

ccharly · 2025-02-26T15:13:56Z

ui/selectors/selectors.js

-  const accountBalance = getSelectedInternalAccount(state)
-    ? getCurrentEthBalance(state)
-    : 0;
+  const accountBalance = selectedAccount ? getCurrentEthBalance(state) : 0;


Just want to flag this here, but what if someone uses MM with only Solana accounts? We might wanna also look for any non-EVM balances now? (I know this was the initial logic, but we might need to keep note of that somewhere)

ccharly · 2025-02-26T15:19:26Z

shared/lib/keyring.ts

+    if (params.address && params.type) {
+      return (
+        keyring.accounts.includes(params.address) &&
+        keyring.type === params.type
+      );
+    }
+    if (params.address) {
+      return keyring.accounts.includes(params.address);
+    }
+    if (params.type) {
+      return keyring.type === params.type;
+    }


We should probably toLowerCase the address here?

ccharly · 2025-02-26T15:24:54Z

ui/store/actions.ts

+            keyring.type === KeyringTypes.hd &&
+            keyring.metadata.id === keyringId,
+        )
+      : keyrings[0];


Could re-use this one:

Suggested change

: keyrings[0];

: defaultPrimaryKeyring;

ccharly · 2025-02-26T15:33:01Z

ui/store/actions.ts

+    const keyrings = getMetaMaskHdKeyrings(getState());
+    const [defaultPrimaryKeyring] = keyrings;
+    let oldAccounts = defaultPrimaryKeyring.accounts;
+
+    ///: BEGIN:ONLY_INCLUDE_IF(multi-srp)
+    const hdKeyring = keyringId
+      ? keyrings.find(
+          (keyring) =>
+            keyring.type === KeyringTypes.hd &&
+            keyring.metadata.id === keyringId,
+        )
+      : keyrings[0];
+
+    if (!hdKeyring) {
+      console.log('Should never reach this. There is always a keyring');
+      throw new Error('Keyring not found');
+    }
+
+    oldAccounts = hdKeyring.accounts;
+    ///: END:ONLY_INCLUDE_IF
+


Small suggestion to make this a bit more "direct":

Suggested change

const keyrings = getMetaMaskHdKeyrings(getState());

const [defaultPrimaryKeyring] = keyrings;

let oldAccounts = defaultPrimaryKeyring.accounts;

///: BEGIN:ONLY_INCLUDE_IF(multi-srp)

const hdKeyring = keyringId

? keyrings.find(

(keyring) =>

keyring.type === KeyringTypes.hd &&

keyring.metadata.id === keyringId,

)

: keyrings[0];

if (!hdKeyring) {

console.log('Should never reach this. There is always a keyring');

throw new Error('Keyring not found');

}

oldAccounts = hdKeyring.accounts;

///: END:ONLY_INCLUDE_IF

const keyrings = getMetaMaskHdKeyrings(getState());

const [defaultPrimaryKeyring] = keyrings;

// The HD keyring to add the account for.

let hdKeyring = defaultPrimaryKeyring;

///: BEGIN:ONLY_INCLUDE_IF(multi-srp)

if (keyringId) {

hdKeyring = keyrings.find(

(keyring) => keyring.metadata.id === keyringId,

);

}

///: END:ONLY_INCLUDE_IF

// Fail-safe in case we could not find the associated HD keyring.

if (!hdKeyring) {

console.error('Should never reach this. There is always a keyring');

throw new Error('Keyring not found');

}

const oldAccounts = hdKeyring.accounts;

NOTE: I've also used console.warn (is console.error better here) rather than a normal log.

ccharly · 2025-02-26T16:39:15Z

lavamoat/browserify/policy-override.json

+    "@metamask/keyring-controller": {
+      "packages": {
+        "ulid": true
+      }
+    },


I wonder if we really needs this override? Since we already have the next one that is strictly related to "@metamask/keyring-controller>ulid"?

Has this been added manually?

I've tried to remove it, and it also removes the policy changes (which also seems unnecessary to me, but I could be wrong here..)

ccharly · 2025-02-26T16:40:37Z

test/e2e/flask/multi-srp/settings-reveal-srp.spec.ts

+import { SECOND_TEST_E2E_SRP, withMultiSRP } from './common-multi-srp';
+
+describe('Multi SRP - Reveal Imported SRP', function (this: Suite) {
+  const testPassword = 'correct horse battery staple';


I would just import WALLET_PASSWORD from test/e2e/helpers.js instead.

ccharly · 2025-02-26T16:42:51Z

test/e2e/flask/multi-srp/import-srp.spec.ts

+import { SECOND_TEST_E2E_SRP, withMultiSRP } from './common-multi-srp';
+
+describe('Multi SRP - Import SRP', function (this: Suite) {
+  const testPassword = 'correct horse battery staple';


I would just import WALLET_PASSWORD from test/e2e/helpers.js instead.

ccharly · 2025-02-26T16:46:22Z

test/e2e/flask/multi-srp/settings-reveal-srp.spec.ts

+describe('Multi SRP - Reveal Imported SRP', function (this: Suite) {
+  const testPassword = 'correct horse battery staple';
+  const firstSRPIndex = 1;
+  const secondSRPIndex = 2;
+
+  it('successfully exports the default SRP', async function () {
+    await withMultiSRP(
+      { title: this.test?.fullTitle() },
+      async (driver: Driver) => {
+        await new HeaderNavbar(driver).openSettingsPage();
+        const settingsPage = new SettingsPage(driver);
+        await settingsPage.check_pageIsLoaded();
+        await settingsPage.goToPrivacySettings();
+
+        const privacySettings = new PrivacySettings(driver);
+        await privacySettings.openRevealSrpQuiz(firstSRPIndex);
+        await privacySettings.completeRevealSrpQuiz();
+        await privacySettings.fillPasswordToRevealSrp(testPassword);
+        await privacySettings.check_srpTextIsDisplayed(FIRST_TEST_E2E_SRP);
+      },
+    );
+  });
+
+  it('successfully exports the imported SRP', async function () {
+    await withMultiSRP(
+      { title: this.test?.fullTitle() },
+      async (driver: Driver) => {
+        await new HeaderNavbar(driver).openSettingsPage();
+        const settingsPage = new SettingsPage(driver);
+        await settingsPage.check_pageIsLoaded();
+        await settingsPage.goToPrivacySettings();
+
+        const privacySettings = new PrivacySettings(driver);
+        await privacySettings.openRevealSrpQuiz(secondSRPIndex);
+        await privacySettings.completeRevealSrpQuiz();
+        await privacySettings.fillPasswordToRevealSrp(testPassword);
+        await privacySettings.check_srpTextIsDisplayed(SECOND_TEST_E2E_SRP);
+      },
+    );
+  });
+});


Suggested change

describe('Multi SRP - Reveal Imported SRP', function (this: Suite) {

const testPassword = 'correct horse battery staple';

const firstSRPIndex = 1;

const secondSRPIndex = 2;

it('successfully exports the default SRP', async function () {

await withMultiSRP(

{ title: this.test?.fullTitle() },

async (driver: Driver) => {

await new HeaderNavbar(driver).openSettingsPage();

const settingsPage = new SettingsPage(driver);

await settingsPage.check_pageIsLoaded();

await settingsPage.goToPrivacySettings();

const privacySettings = new PrivacySettings(driver);

await privacySettings.openRevealSrpQuiz(firstSRPIndex);

await privacySettings.completeRevealSrpQuiz();

await privacySettings.fillPasswordToRevealSrp(testPassword);

await privacySettings.check_srpTextIsDisplayed(FIRST_TEST_E2E_SRP);

},

);

});

it('successfully exports the imported SRP', async function () {

await withMultiSRP(

{ title: this.test?.fullTitle() },

async (driver: Driver) => {

await new HeaderNavbar(driver).openSettingsPage();

const settingsPage = new SettingsPage(driver);

await settingsPage.check_pageIsLoaded();

await settingsPage.goToPrivacySettings();

const privacySettings = new PrivacySettings(driver);

await privacySettings.openRevealSrpQuiz(secondSRPIndex);

await privacySettings.completeRevealSrpQuiz();

await privacySettings.fillPasswordToRevealSrp(testPassword);

await privacySettings.check_srpTextIsDisplayed(SECOND_TEST_E2E_SRP);

},

);

});

});

const exportSrp = async (driver: Driver, srpIndex: number, srp: string) => {

await new HeaderNavbar(driver).openSettingsPage();

const settingsPage = new SettingsPage(driver);

await settingsPage.check_pageIsLoaded();

await settingsPage.goToPrivacySettings();

const privacySettings = new PrivacySettings(driver);

await privacySettings.openRevealSrpQuiz(srpIndex);

await privacySettings.completeRevealSrpQuiz();

await privacySettings.fillPasswordToRevealSrp(testPassword);

await privacySettings.check_srpTextIsDisplayed(srp);

};

describe('Multi SRP - Reveal Imported SRP', function (this: Suite) {

const testPassword = 'correct horse battery staple';

it('successfully exports the default SRP', async function () {

await withMultiSRP(

{ title: this.test?.fullTitle() },

async (driver: Driver) => {

await new exportSrp(driver, 1, FIRST_TEST_E2E_SRP);

},

);

});

it('successfully exports the imported SRP', async function () {

await withMultiSRP(

{ title: this.test?.fullTitle() },

async (driver: Driver) => {

await new exportSrp(driver, 2, SECOND_TEST_E2E_SRP);

},

);

});

});

ccharly · 2025-02-26T16:47:25Z

ui/components/multichain/multi-srp/import-srp/import-srp.test.tsx

+    });
+  });
+
+  it('should log an error and not call onActionComplete on import failure', async () => {


Suggested change

it('should log an error and not call onActionComplete on import failure', async () => {

it('logs an error and not call onActionComplete on import failure', async () => {

ccharly · 2025-02-26T16:47:33Z

ui/components/multichain/multi-srp/import-srp/import-srp.test.tsx

+    expect(getByText('Import wallet')).not.toBeEnabled();
+  });
+
+  it('should call addNewMnemonicToVault and showAlert on successful import', async () => {


Suggested change

it('should call addNewMnemonicToVault and showAlert on successful import', async () => {

it('calls addNewMnemonicToVault and showAlert on successful import', async () => {

ccharly · 2025-02-26T16:47:50Z

ui/components/multichain/multi-srp/import-srp/import-srp.test.tsx

+    });
+  });
+
+  it('should not enable the "Import wallet" button when the secret recovery phrase is empty', async () => {


Suggested change

it('should not enable the "Import wallet" button when the secret recovery phrase is empty', async () => {

it('does not enable the "Import wallet" button when the secret recovery phrase is empty', async () => {

ccharly · 2025-02-26T16:47:58Z

ui/components/multichain/multi-srp/import-srp/import-srp.test.tsx

+    jest.restoreAllMocks();
+  });
+
+  it('should enable the "Import wallet" button when a valid secret recovery phrase is entered', async () => {


Suggested change

it('should enable the "Import wallet" button when a valid secret recovery phrase is entered', async () => {

it('enables the "Import wallet" button when a valid secret recovery phrase is entered', async () => {

## **Description** This PR introduces importing srps as a new feature. It is split from a previous [pr](#29816)  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30598?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** **Importing a new SRP** 1. Click on the account selector 2. Click on connect more 3. Click on `Import secret recovery phrase` 4. Paste in a SRP 5. Continue 6. See a new account is created 7. Click on the account selector and see new pills indicating the SRP numbers ## **Screenshots/Recordings**  ### **Before** ### **After** Importing a new SRP https://github.com/user-attachments/assets/ac349e02-1dd4-4e87-86a7-3e21c7b2cd7b ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Charly Chevalier <[email protected]>

PatrykLucka and others added 30 commits December 11, 2024 13:59

feat: multip SRP PoC

ce87824

feat(multi-srp): add keyring id

5b9bf58

chore(multi-srp): add code fences

cc9cd94

chore(multi-srp): add import codefence, tests and story

ae06ccf

chore(multi-srp): change js component to tsx + use accountController …

9771fe5

…instead of preferencesController

feat(multi-srp): add more accounts from imported SRP if they have any…

33740d1

… balance

Apply suggestions from code review

ef4d9e2

Co-authored-by: Monte Lai <[email protected]>

chore: Apply suggestions from code review

a2a07db

feat(multi-srp): use toast as success message

8c01287

chore: use preview build for keyring-controller

c169e2b

fix: update to pass typeIndex as param

a5cfec3

feat(multi-srp): add select srp UI

c26ac36

feat: add test for reveal seed

4648cd9

feat: add generateNewHdKeyring

491e3bb

feat(multi-srp): create account from srp UI

b62d838

Merge branch 'mmmsrp-9' into multi-srp-mvp

edc978f

refactor: use keyring index instead of id and typeIndex

ff891e0

feat: add import srp word list ui

2e69c3b

feat: multip SRP PoC

b3b1522

feat(multi-srp): add keyring id

6824d52

chore(multi-srp): add code fences

6fc4744

chore(multi-srp): add import codefence, tests and story

e904582

chore(multi-srp): change js component to tsx + use accountController …

c5d819a

…instead of preferencesController

feat(multi-srp): add more accounts from imported SRP if they have any…

1cd827b

… balance

Apply suggestions from code review

d18fd69

Co-authored-by: Monte Lai <[email protected]>

chore: Apply suggestions from code review

f16ae0a

feat(multi-srp): use toast as success message

a26d104

chore: use preview build for keyring-controller

8e612fc

feat(multi-srp): add select srp UI

2013282

feat(multi-srp): create account from srp UI

079bffe

ccharly reviewed Feb 26, 2025

View reviewed changes

ui/components/multichain/account-details/account-details-display.js Show resolved Hide resolved

ccharly reviewed Feb 26, 2025

View reviewed changes

ui/components/multichain/account-details/account-details-display.js Show resolved Hide resolved

ccharly reviewed Feb 26, 2025

View reviewed changes

montelaidev added 4 commits February 26, 2025 21:25

fix: address comments

b3b3518

fix: renaming import

06ee5be

fix: update copy

4418a35

fix: remove comma

00c7c20

montelaidev added 5 commits February 26, 2025 21:45

fix: lint

4b9e6ba

refactor: use getMetaMaskAccounts

728bf56

refactor: display balances

d95b02e

fix: fence to allow getMetaMaskHdKeyrings

57c79c1

fix: lint

cac6339

ccharly reviewed Feb 26, 2025

View reviewed changes

test/e2e/flask/multi-srp/add-accounts.spec.ts Outdated Show resolved Hide resolved

ccharly reviewed Feb 26, 2025

View reviewed changes

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

ccharly reviewed Feb 26, 2025

View reviewed changes

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

ccharly reviewed Feb 26, 2025

View reviewed changes

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

montelaidev added 2 commits February 26, 2025 22:49

fix: srplist account balance

5f2aeaf

fix: fence and remove comments

945c285

aganglada reviewed Feb 26, 2025

View reviewed changes

ccharly reviewed Feb 26, 2025

View reviewed changes

montelaidev mentioned this pull request Feb 27, 2025

feat: import srp #30598

Merged

7 tasks

montelaidev added the DO-NOT-MERGE Pull requests that should not be merged label Mar 5, 2025

montelaidev closed this Mar 25, 2025

github-actions bot locked and limited conversation to collaborators Mar 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: multisrp ui #29816

feat: multisrp ui #29816

montelaidev commented Jan 21, 2025 •

edited

Loading

danroc commented Feb 26, 2025

montelaidev commented Feb 26, 2025

aganglada Feb 25, 2025

aganglada Feb 26, 2025

montelaidev Feb 26, 2025

aganglada Feb 26, 2025

montelaidev Feb 27, 2025

aganglada Feb 26, 2025

aganglada Feb 26, 2025

aganglada Feb 26, 2025

aganglada Feb 26, 2025

metamaskbot commented Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

ccharly Feb 26, 2025

	it('should log an error and not call onActionComplete on import failure', async () => {
	it('logs an error and not call onActionComplete on import failure', async () => {

	it('should call addNewMnemonicToVault and showAlert on successful import', async () => {
	it('calls addNewMnemonicToVault and showAlert on successful import', async () => {

	it('should not enable the "Import wallet" button when the secret recovery phrase is empty', async () => {
	it('does not enable the "Import wallet" button when the secret recovery phrase is empty', async () => {

	it('should enable the "Import wallet" button when a valid secret recovery phrase is entered', async () => {
	it('enables the "Import wallet" button when a valid secret recovery phrase is entered', async () => {

feat: multisrp ui #29816

feat: multisrp ui #29816

Conversation

montelaidev commented Jan 21, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

After

Pre-merge author checklist

Pre-merge reviewer checklist

danroc commented Feb 26, 2025

montelaidev commented Feb 26, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Feb 26, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

montelaidev commented Jan 21, 2025 •

edited

Loading