feat: import srp #30598

montelaidev · 2025-02-27T00:59:49Z

Description

This PR introduces importing srps as a new feature. It is split from a previous pr

Related issues

Fixes:

Manual testing steps

Importing a new SRP

Click on the account selector
Click on connect more
Click on Import secret recovery phrase
Paste in a SRP
Continue
See a new account is created
Click on the account selector and see new pills indicating the SRP numbers

Screenshots/Recordings

Before

After

Importing a new SRP

Screen.Recording.2025-02-14.at.17.26.32.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-27T01:00:00Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-27T03:55:01Z

Builds ready [3ccc9f1]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2013 ± 132 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	364	2482	1829	516	248
		domContentLoaded	1635	2705	1975	261	125
		load	1649	2716	2013	275	132
		domInteractive	26	172	51	32	15
		backgroundConnect	12	169	47	41	20
		firstReactRender	19	89	45	24	12
		getState	6	73	27	21	10
		initialActions	0	1	0	0	0
		loadScripts	1216	2177	1493	215	103
		setupStore	8	92	29	25	12
		uiStartup	1938	3267	2356	377	181

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 627 Bytes (0.01%)
common: 1.46 KiB (0.01%)

metamaskbot · 2025-02-27T05:29:00Z

Builds ready [ea82ea4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1862 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	433	2491	1789	377	181
		domContentLoaded	1577	2413	1830	206	99
		load	1623	2498	1862	215	103
		domInteractive	28	141	49	28	14
		backgroundConnect	9	89	36	27	13
		firstReactRender	16	73	38	22	11
		getState	6	57	16	15	7
		initialActions	0	1	0	0	0
		loadScripts	1182	1872	1378	177	85
		setupStore	8	65	25	21	10
		uiStartup	1872	2689	2122	219	105

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 627 Bytes (0.01%)
common: 1.34 KiB (0.01%)

metamaskbot · 2025-02-27T07:28:02Z

Builds ready [c3ea3b0]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2020 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1751	2695	2017	207	100
		domContentLoaded	1743	2645	1991	199	96
		load	1749	2747	2020	214	103
		domInteractive	30	223	53	42	20
		backgroundConnect	10	101	32	24	12
		firstReactRender	17	71	29	18	9
		getState	6	74	28	23	11
		initialActions	0	1	0	0	0
		loadScripts	1271	2055	1480	171	82
		setupStore	8	62	27	22	10
		uiStartup	2017	3219	2306	258	124

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 627 Bytes (0.01%)
common: 1.34 KiB (0.01%)

ccharly · 2025-02-27T08:36:24Z

test/e2e/page-objects/pages/account-list-page.ts

@@ -46,7 +46,7 @@ class AccountListPage {
    '[data-testid="multichain-account-menu-popover-add-watch-only-account"]';

  private readonly addHardwareWalletButton = {
-    text: 'Add hardware wallet',
+    text: 'Hardware wallet',


For future reviewers: Those changes are expected, and match the new designs (the "Add " prefix has now been dropped for most "add*Account" labels)

ui/components/app/toast-master/toast-master.js

ccharly · 2025-02-27T09:03:15Z

app/_locales/en/messages.json

@@ -197,7 +197,7 @@
    "message": "Add friends and addresses you trust"


Comment for the entire file:

Since this PR also uses the new "account list" design, I've spotted some differences for some kind of accounts:

addHardwareWallet, addNewBitcoinAccount and addNewBitcoinTestnetAccount could be renamed to add*Label (to match the new naming convention)

addNewBitcoinAccount and addNewBitcoinTestnetAccount still uses the old description "Add a new ...", we could remove those (we can double-check with the designs for this)

addNewAccount is no longer used, so we can remove it IMO

ui/components/multichain/multi-srp/import-srp/import-srp.test.tsx

ui/components/multichain/multichain-components.scss

ui/ducks/app/app.ts

ui/selectors/selectors.js

shared/lib/keyring.ts

ccharly · 2025-02-27T10:20:04Z

app/scripts/metamask-controller.js

+      const alreadyImportedSRP = await this.keyringController
+        .getKeyringsByType(KeyringTypes.hd)
+        .some((keyring) => {
          return (
-            keyring.accounts.includes(address) &&
-            keyring.type === KeyringTypes.hd
+            Buffer.from(
+              this._convertEnglishWordlistIndicesToCodepoints(keyring.mnemonic),
+            ).toString('utf8') === mnemonic
          );
        });


Since this logic relies on a @deprecated method, we could move it to the KeyringController? That would also hide the "detailed implementation" about how mnemonics are being encoded for HD keyrings.

Or should we have a withKeyrings(keyringType) (note the s) that we would use similarly to withKeyring? Just random thoughts on this.

I'd like to get your opinion (if possible) on this @mikesposito 😄 thanks!

(For now, adding a TODO seems like a good option)

// TODO: `getKeyringsByType` is deprecated, this logic should probably be moved to the `KeyringController`.

i think withKeyrings(keyringType) would be pretty helpful.

Besides withKeyrings we could also simply iterate through the keyrings list on KeyringController.state and get the mnemonic with primitives we already have, like withKeyring

Though, I'm wondering if this is really needed here, since it's the controller to check for duplicates: https://github.com/MetaMask/core/blob/5b74b24875491b480a01dd5d950e04020fba7e26/packages/keyring-controller/src/KeyringController.ts#L2483
The HD keyring will always include at least one address, and if the same SRP is imported twice, the second one will throw an error on KeyrignController

Yup, IMO, we should have this kind of guarantee at the controller level.

Though, currently the #checkForDuplicate do not check anything for HD keyrings (if I read that correctly)? But I do agree that having that we should have a check there (and checking the mnemonic together would allow to have a "specific error" like KeyringControllerError.DuplicatedMnemonic rather than KeyringControllerError.DuplicatedAccount).

That will be also useful for mobile integration IMO.

WDYT @montelaidev?

It doesn't check the specific mnemonic that is being imported, but it throws error if there are two keyrings with the same address. I'm assuming that the same SRP will always create the same first account, and since we automatically add one when importing the SRP, that means we'll have at least one duplicated account when calling #checkForDuplicate

As discussed together internally, the current logic of #checkForDuplicates is not covering every cases (and not this one 🙈), here's the ticket to track this:

KeyringController does not prevent duplicate accounts properly core#5411

…-srp

shared/lib/keyring.test.ts

ui/components/app/toast-master/selectors.ts

ui/components/app/toast-master/toast-master.js

metamaskbot · 2025-02-27T15:54:31Z

Builds ready [51550c4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1752 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1500	1978	1752	139	67
		domContentLoaded	1490	1940	1720	137	66
		load	1504	1967	1752	137	66
		domInteractive	25	133	42	24	12
		backgroundConnect	10	103	41	26	13
		firstReactRender	15	69	37	21	10
		getState	5	70	18	19	9
		initialActions	0	1	0	0	0
		loadScripts	1085	1478	1289	110	53
		setupStore	7	62	20	19	9
		uiStartup	1756	2285	2015	149	72

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 627 Bytes (0.01%)
common: 1.31 KiB (0.01%)

ui/components/multichain/account-list-menu/account-list-menu.tsx

ui/components/multichain/multi-srp/import-srp/import-srp.test.tsx

ui/components/multichain/multi-srp/import-srp/import-srp.tsx

ccharly · 2025-02-28T09:50:01Z

app/scripts/metamask-controller.js

+      const alreadyImportedSRP = await this.keyringController
+        .getKeyringsByType(KeyringTypes.hd)
+        .some((keyring) => {
          return (
-            keyring.accounts.includes(address) &&
-            keyring.type === KeyringTypes.hd
+            Buffer.from(
+              this._convertEnglishWordlistIndicesToCodepoints(keyring.mnemonic),
+            ).toString('utf8') === mnemonic
          );
        });


Yup, IMO, we should have this kind of guarantee at the controller level.

Though, currently the #checkForDuplicate do not check anything for HD keyrings (if I read that correctly)? But I do agree that having that we should have a check there (and checking the mnemonic together would allow to have a "specific error" like KeyringControllerError.DuplicatedMnemonic rather than KeyringControllerError.DuplicatedAccount).

That will be also useful for mobile integration IMO.

WDYT @montelaidev?

montelaidev · 2025-02-28T13:02:42Z

Yup, IMO, we should have this kind of guarantee at the controller level.

Though, currently the #checkForDuplicate do not check anything for HD keyrings (if I read that correctly)? But I do agree that having that we should have a check there (and checking the mnemonic together would allow to have a "specific error" like KeyringControllerError.DuplicatedMnemonic rather than KeyringControllerError.DuplicatedAccount).

That will be also useful for mobile integration IMO.

Yea it would be much better to do it in the controller

ccharly · 2025-03-03T14:31:38Z

ui/components/multichain/multi-srp/import-srp/import-srp.tsx

@@ -0,0 +1,309 @@
+import React, { useCallback, useMemo, useState } from 'react';


Note for the entire file: As discussed internally with @montelaidev, this file will be refactored in a follow-up PR to avoid duplicating the logic with input-srp.

So I will adds more comments on this new PR once this one will be merged.

See: https://github.com/MetaMask/metamask-extension/pull/30598/files#r1977094784

ui/components/multichain/multi-srp/import-srp/import-srp.test.tsx

shared/lib/keyring.test.ts

app/scripts/metamask-controller.js

Co-authored-by: Charly Chevalier <[email protected]>

metamaskbot · 2025-03-04T15:40:34Z

Builds ready [e9e193e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1825 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1604	2070	1823	129	62
		domContentLoaded	1592	2021	1804	125	60
		load	1604	2066	1825	127	61
		domInteractive	27	129	42	23	11
		backgroundConnect	11	63	24	16	8
		firstReactRender	16	79	42	26	13
		getState	4	60	15	18	8
		initialActions	0	1	0	0	0
		loadScripts	1181	1585	1343	114	55
		setupStore	8	61	22	20	10
		uiStartup	1834	2326	2083	142	68

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 632 Bytes (0.01%)
common: 1.31 KiB (0.01%)

ccharly · 2025-03-04T16:21:00Z

app/_locales/en/messages.json

+  "addBitcoinAccountLabel": {
+    "message": "Add a new Bitcoin account (Beta)"
+  },
+  "addBitcoinTestnetAccountLabel": {
+    "message": "Add a new Bitcoin account (Testnet)"
+  },


Related to: https://github.com/MetaMask/metamask-extension/pull/30598/files#r1973162748

Are we also renaming those to Bitcoin account?

shared/lib/keyring.test.ts

test/e2e/page-objects/pages/account-list-page.ts

ui/components/multichain/multi-srp/import-srp/import-srp.test.tsx

ccharly · 2025-03-04T16:44:51Z

Tested ✅

$ jq '.metamask.internalAccounts.accounts | to_entries[] | .value.address' state.json

"0x33f5be2b61b33b4423e4f15fdd9a344c0b2e3a0d"
"0x8e29b63f510f6f3714fa23c7cc0614e3a928fb16"

$ jq '.metamask | {keyrings, keyringsMetadata}' state.json

{
  "keyrings": [
    {
      "type": "HD Key Tree",
      "accounts": [
        "0x33f5be2b61b33b4423e4f15fdd9a344c0b2e3a0d"
      ]
    },
    {
      "type": "HD Key Tree",
      "accounts": [
        "0x8e29b63f510f6f3714fa23c7cc0614e3a928fb16"
      ]
    }
  ],
  "keyringsMetadata": [
    {
      "id": "01JNH032HRW8A1CYC9W90WDAFP",
      "name": ""
    },
    {
      "id": "01JNH053FZDK57D3SR1DMMK4R3",
      "name": ""
    }
  ]
}

Found one small UI issue, the "plus" sign is bigger for Ethereum than for Solana:

metamaskbot · 2025-03-05T03:59:11Z

Builds ready [2d0ecd9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2022 ± 79 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	253	2242	1838	546	262
		domContentLoaded	1690	2210	1983	156	75
		load	1702	2247	2022	164	79
		domInteractive	30	124	52	23	11
		backgroundConnect	12	118	42	29	14
		firstReactRender	17	77	30	19	9
		getState	7	63	19	15	7
		initialActions	0	1	0	0	0
		loadScripts	1243	1643	1484	124	60
		setupStore	9	71	28	23	11
		uiStartup	2025	2615	2302	173	83

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 632 Bytes (0.01%)
common: 1.31 KiB (0.01%)

ccharly

Thanks a lot for all those changes, LGTM now 😄 (and already tested, see my previous comment)

metamaskbot · 2025-03-05T09:41:12Z

Builds ready [487db25]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1546 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1377	1825	1547	98	47
		domContentLoaded	1365	1806	1524	98	47
		load	1375	1825	1546	96	46
		domInteractive	14	76	37	18	9
		backgroundConnect	9	77	27	19	9
		firstReactRender	14	66	18	11	5
		getState	4	52	16	17	8
		initialActions	0	0	0	0	0
		loadScripts	987	1388	1128	84	40
		setupStore	7	62	16	17	8
		uiStartup	1510	2137	1754	126	60

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 632 Bytes (0.01%)
common: 1.29 KiB (0.01%)

montelaidev added 2 commits February 27, 2025 08:40

feat: add import srp

d38153f

fix: styling

a1e05e9

metamaskbot added the team-accounts label Feb 27, 2025

fix: test and lint

3ccc9f1

fix: remove unused locale

ea82ea4

montelaidev marked this pull request as ready for review February 27, 2025 06:46

montelaidev requested a review from a team as a code owner February 27, 2025 06:46

fix: add to lowerCase

c3ea3b0

montelaidev mentioned this pull request Feb 27, 2025

feat: add accounts to a specific srp #30604

Merged

7 tasks

ccharly reviewed Feb 27, 2025

View reviewed changes

montelaidev added 5 commits February 27, 2025 19:38

Merge remote-tracking branch 'origin/main' into feat/multi-srp-import…

ae7b972

…-srp

fix: address comments

0ca139a

feat: add test to check for clearing of clipboard

7ceb5a2

fix: label copy

eeac136

fix: tests

f1114c8

ccharly reviewed Feb 27, 2025

View reviewed changes

shared/lib/keyring.test.ts Show resolved Hide resolved

ccharly reviewed Feb 27, 2025

View reviewed changes

ui/components/app/toast-master/selectors.ts Outdated Show resolved Hide resolved

ccharly reviewed Feb 27, 2025

View reviewed changes

ui/components/app/toast-master/toast-master.js Outdated Show resolved Hide resolved

fix: rename from SRP to Srp

51550c4

ccharly reviewed Feb 28, 2025

View reviewed changes

fix: address comments

f684cab

montelaidev added 2 commits February 28, 2025 21:16

Merge branch 'main' into feat/multi-srp-import-srp

1dd7251

fix: add to beta

4f739e0

montelaidev added 2 commits March 3, 2025 22:19

fix: update en_gb messages

352b597

feat: add test if no every selectors are matching

4fc7f9e

ccharly reviewed Mar 3, 2025

View reviewed changes

montelaidev added 2 commits March 3, 2025 22:49

fix: naming

012b71c

refactor: put button into const

7d2810d

ccharly reviewed Mar 3, 2025

View reviewed changes

app/scripts/metamask-controller.js Show resolved Hide resolved

montelaidev and others added 4 commits March 4, 2025 16:40

Update app/scripts/metamask-controller.js

ec4dfdd

Co-authored-by: Charly Chevalier <[email protected]>

Update shared/lib/keyring.test.ts

37d7eb8

Co-authored-by: Charly Chevalier <[email protected]>

fix: locales

8f39923

Merge branch 'main' into feat/multi-srp-import-srp

e9e193e

ccharly reviewed Mar 4, 2025

View reviewed changes

fix: address comments

2d0ecd9

fix: locale

487db25

ccharly approved these changes Mar 5, 2025

View reviewed changes

NidhiKJha approved these changes Mar 5, 2025

View reviewed changes

github-project-automation bot moved this from Review in progress to Review finalised - Ready to be merged in PR review queue Mar 5, 2025

montelaidev added this pull request to the merge queue Mar 5, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2025

montelaidev added this pull request to the merge queue Mar 5, 2025

montelaidev mentioned this pull request Mar 5, 2025

feat: add reveal srp #30641

Merged

7 tasks

Merged via the queue into main with commit 6210f00 Mar 5, 2025
74 checks passed

montelaidev deleted the feat/multi-srp-import-srp branch March 5, 2025 14:15

github-actions bot locked and limited conversation to collaborators Mar 5, 2025

metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: import srp #30598

feat: import srp #30598

montelaidev commented Feb 27, 2025 •

edited

Loading

github-actions bot commented Feb 27, 2025

metamaskbot commented Feb 27, 2025

metamaskbot commented Feb 27, 2025

metamaskbot commented Feb 27, 2025

ccharly Feb 27, 2025

ccharly Feb 27, 2025

ccharly Feb 27, 2025

montelaidev Feb 27, 2025

mikesposito Feb 28, 2025

ccharly Feb 28, 2025

mikesposito Feb 28, 2025

ccharly Mar 3, 2025

metamaskbot commented Feb 27, 2025

ccharly Feb 28, 2025

montelaidev commented Feb 28, 2025

ccharly Mar 3, 2025

metamaskbot commented Mar 4, 2025

ccharly Mar 4, 2025

ccharly commented Mar 4, 2025

metamaskbot commented Mar 5, 2025

ccharly left a comment

metamaskbot commented Mar 5, 2025

		@@ -197,7 +197,7 @@
		"message": "Add friends and addresses you trust"

		@@ -0,0 +1,309 @@
		import React, { useCallback, useMemo, useState } from 'react';

feat: import srp #30598

feat: import srp #30598

Conversation

montelaidev commented Feb 27, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 27, 2025

metamaskbot commented Feb 27, 2025

metamaskbot commented Feb 27, 2025

metamaskbot commented Feb 27, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Feb 27, 2025

Choose a reason for hiding this comment

montelaidev commented Feb 28, 2025

Choose a reason for hiding this comment

metamaskbot commented Mar 4, 2025

Choose a reason for hiding this comment

ccharly commented Mar 4, 2025

metamaskbot commented Mar 5, 2025

ccharly left a comment

Choose a reason for hiding this comment

metamaskbot commented Mar 5, 2025

montelaidev commented Feb 27, 2025 •

edited

Loading