Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for GHA resource attributes #19

Merged

Conversation

jd
Copy link
Member

@jd jd commented Dec 17, 2024

Fixes MRGFY-4457

@jd
Copy link
Member Author

jd commented Dec 17, 2024

This pull request is part of a stack:

  1. feat: add support for GHA resource attributes (#19) 👈
  2. fix: pass repo name in export URL (#20)

Copy link

mergify bot commented Dec 17, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Approval

Wonderful, this rule succeeded.
  • #approved-reviews-by >= 1

🟢 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = test (3.10)
    • check-success = test (3.11)
    • check-success = test (3.12)
    • check-success = test (3.13)

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • label = skip changelog
    • -title ~= ^feat
    • label = need changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@jd jd force-pushed the devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 branch from 5cbbaf5 to b6ca67c Compare December 17, 2024 10:32
@jd jd force-pushed the devs/jd/gha-provider/Ia8791aa527ccc8e0420a86bb023bdf7ae43f5775 branch from d596d33 to fe1b905 Compare December 17, 2024 10:32
@jd jd force-pushed the devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 branch from b6ca67c to adb179e Compare December 17, 2024 10:36
@jd jd force-pushed the devs/jd/gha-provider/Ia8791aa527ccc8e0420a86bb023bdf7ae43f5775 branch 2 times, most recently from 79d5daf to 0c2600c Compare December 17, 2024 10:45
@mergify mergify bot requested a review from a team December 17, 2024 10:46
Base automatically changed from devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 to main December 17, 2024 10:56
Copy link

mergify bot commented Dec 17, 2024

@jd this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Dec 17, 2024
Change-Id: Ia8791aa527ccc8e0420a86bb023bdf7ae43f5775
@jd jd force-pushed the devs/jd/gha-provider/Ia8791aa527ccc8e0420a86bb023bdf7ae43f5775 branch from 0c2600c to 41e3ab8 Compare December 17, 2024 12:43
@mergify mergify bot removed the conflict label Dec 17, 2024
@mergify mergify bot dismissed DouglasBlackwood’s stale review December 17, 2024 12:44

Pull request has been modified.

@mergify mergify bot requested a review from a team December 17, 2024 12:44
@mergify mergify bot merged commit 58ba98c into main Dec 17, 2024
14 checks passed
@mergify mergify bot added the queued label Dec 17, 2024
@mergify mergify bot deleted the devs/jd/gha-provider/Ia8791aa527ccc8e0420a86bb023bdf7ae43f5775 branch December 17, 2024 13:06
@mergify mergify bot removed the queued label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants