Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cicd provider detector #18

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: add cicd provider detector #18

merged 1 commit into from
Dec 17, 2024

Conversation

jd
Copy link
Member

@jd jd commented Dec 16, 2024 •
edited
Loading

Related to MRGFY-4457

@jd jd mentioned this pull request Dec 16, 2024
Merged
@jd
Copy link
Member Author

jd commented Dec 16, 2024 •
edited
Loading

This pull request is part of a stack:

  1. feat: add cicd provider detector (#18) 👈
  2. feat: add support for GHA resource attributes (#19)
  3. fix: pass repo name in export URL (#20)

@jd jd mentioned this pull request Dec 16, 2024
Merged
@jd jd force-pushed the devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 branch from 1766beb to 6a5505e Compare December 16, 2024 16:59
@mergify Mergify
Copy link

mergify bot commented Dec 16, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Approval

Wonderful, this rule succeeded.
  • #approved-reviews-by >= 1

🟢 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = test (3.10)
    • check-success = test (3.11)
    • check-success = test (3.12)
    • check-success = test (3.13)

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • label = skip changelog
    • -title ~= ^feat
    • label = need changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@jd jd force-pushed the devs/jd/gha-provider/Ibff24d023356bdc10a1a8347295d534c745c4d2d branch from 8ee7c6e to 3d2cd3d Compare December 17, 2024 08:54
@jd jd force-pushed the devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 branch from 6a5505e to 27c520c Compare December 17, 2024 08:54
@jd jd force-pushed the devs/jd/gha-provider/Ibff24d023356bdc10a1a8347295d534c745c4d2d branch from 3d2cd3d to ec7f54f Compare December 17, 2024 09:31
@jd jd force-pushed the devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 branch 3 times, most recently from 2ec93cc to e2db820 Compare December 17, 2024 09:33
Base automatically changed from devs/jd/gha-provider/Ibff24d023356bdc10a1a8347295d534c745c4d2d to main December 17, 2024 09:36
@jd jd force-pushed the devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 branch from e2db820 to 5cbbaf5 Compare December 17, 2024 09:43
@jd jd mentioned this pull request Dec 17, 2024
Merged
@jd jd force-pushed the devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 branch from 5cbbaf5 to b6ca67c Compare December 17, 2024 10:32
@jd
feat: add cicd provider detector
adb179e 
Related to MRGFY-4457

Change-Id: I39965fbdb72833c4e371b5bf345a24e3a2f91875
@jd jd force-pushed the devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 branch from b6ca67c to adb179e Compare December 17, 2024 10:36
@mergify mergify bot requested a review from a team December 17, 2024 10:38
@jd jd mentioned this pull request Dec 17, 2024
Merged
@mergify mergify bot merged commit 3c76330 into main Dec 17, 2024
9 checks passed
@mergify mergify bot added the queued label Dec 17, 2024
@mergify mergify bot deleted the devs/jd/gha-provider/I39965fbdb72833c4e371b5bf345a24e3a2f91875 branch December 17, 2024 10:56
@mergify mergify bot removed the queued label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sileht sileht sileht approved these changes

@DouglasBlackwood DouglasBlackwood DouglasBlackwood approved these changes

Assignees
No one assigned
Labels
skip changelog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jd @sileht @DouglasBlackwood