Move lcov 3.6 #10452
Merged
Move lcov 3.6 #10452
+5
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjwtaylor
force-pushed
the
move-lcov-3.6
branch
from
f1cbfb2 to
7236443
Compare
This was referenced Oct 15, 2025
bjwtaylor
added
needs-review
4 tasks
mpg
requested changes
Oct 24, 2025
Contributor
mpg
left a comment
mpg
left a comment
There was a problem hiding this comment.
Looks good to me except I think we need to update the framework pointer in order for the script to be present in its new location.
mpg
added
needs-work
and removed
needs-review
bjwtaylor
force-pushed
the
move-lcov-3.6
branch
from
8eba148 to
c883b37
Compare
added 3 commits
October 24, 2025 12:03
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
bjwtaylor
force-pushed
the
move-lcov-3.6
branch
from
c883b37 to
82d2fb8
Compare
valeriosetti
approved these changes
Oct 24, 2025
valeriosetti
added
needs-review
valeriosetti
approved these changes
Nov 4, 2025
valeriosetti
requested changes
Nov 4, 2025
Contributor
valeriosetti
left a comment
valeriosetti
left a comment
There was a problem hiding this comment.
I apologize for the last minute change, but I think I've found something worth to be fixed
CMakeLists.txt
Outdated
| # 3. Run framework/scripts/lcov.sh to generate an HTML report. | ||
| ADD_CUSTOM_TARGET(lcov | ||
| COMMAND scripts/lcov.sh | ||
| COMMAND framework/scripts/lcov.sh |
Contributor
There was a problem hiding this comment.
Despite my previous approval I think I would suggest a change here. Can we make the framework path a bit more generic using MBEDTLS_FRAMEWORK_DIR as you did in the development branch PR?
mpg
reviewed
Nov 4, 2025
Contributor
mpg
left a comment
mpg
left a comment
There was a problem hiding this comment.
LGTM other than the point already noted by Valerio.
Signed-off-by: Ben Taylor <[email protected]>
Contributor
|
I have cherry-picked the change of |
valeriosetti
approved these changes
Nov 4, 2025
mpg
added
approved
Contributor
|
The release job succeeded, removing 'needs-ci'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove lcov.sh as this will be moved to the framework contributes Mbed-TLS/mbedtls-framework#93
This PR is part of a multistage PR, however the code changes involved appear to not effect the CI so it can be merged in any order. However it is suggested it is merged in the following order.
PR checklist
Release job for coverage testing: https://ci.trustedfirmware.org/view/Mbed-TLS/job/mbedtls-release-ci-testing/32/