-
Notifications
You must be signed in to change notification settings - Fork 42
Add adapted lcov.sh to the framework #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What I suggest when moving files for the next time:
In this way it's easier to tell what was done do adapt the script to work with mbedtls 4.0/3.6 and tf-psa-crypto. I can still do it locally of course, but it's less immediate. |
This is just my curiosity, not a problem for this PR: does it make any difference in terms of coverage if we're building in-tree or out-of-tree? |
So, it shouldn't do. The coverage is based on the tests you run, so if you are running the same tests you should get the same result. It would be an interesting test to do though. |
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
mpg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
| @@ -0,0 +1,101 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: not a big fan of the commit structure here. In the future, please start with an identical copy, and make changes as a separate commit. This makes it much easier to see what changed.
As a general rule, moves (of files, functions, or large chunks of code), as well a large whitespace changes (re-indent / fix code style), should be separated as much as possible from actual changes. This makes it much easier to review what's going on.
(No need to rewrite history here at this point, but please keep in mind for the future.)
Description
Add adapted lcov.sh to the framework. I've uploaded the rudimentary test script that I used to validate the change here https://github.com/bjwtaylor/mbedtls/blob/lcov-test/scripts/test.sh. It doesn't inspect the report, however it validates it has been created not sure if this is useful in this PR? Let me know what people think? contributes #93
This PR is part of a multistage PR, however the code changes involved appear to not effect the CI so it can be merged in any order. However it is suggested it is merged in the following order.
PR checklist