Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort npm audit pending list by severity #23319

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jan 28, 2025

@jrafanie Please review. This was used to rebuild the yarn audit lists in ManageIQ/manageiq-ui-classic#9329 and ManageIQ/manageiq-ui-service#1947

cc @GilbertCherrie

@jrafanie
Copy link
Member

Weird, it failed.

  1) BlacklistedEvent.seed re-seeds deleted event filters
     Failure/Error: expect(described_class.count).to eq(total_blacklist_entry_count - 1)

       expected: 129
            got: 127

       (compared using ==)
     # ./spec/models/blacklisted_event_spec.rb:14:in `block (3 levels) in <top (required)>'

Sporadic failure?

@Fryguy
Copy link
Member Author

Fryguy commented Jan 28, 2025

@jrafanie More likely fallout from the work being done in #19707

@Fryguy Fryguy closed this Jan 28, 2025
@Fryguy Fryguy reopened this Jan 28, 2025
@jrafanie jrafanie merged commit 50bd91d into ManageIQ:master Jan 28, 2025
12 of 14 checks passed
@Fryguy Fryguy deleted the sort_severity_npm_audit branch January 28, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants