Merge pull request #23319 from Fryguy/sort_severity_npm_audit

Sort npm audit pending list by severity
ManageIQ · Jan 28, 2025 · 50bd91d · 50bd91d
2 parents 6518977 + c1e58f3
commit 50bd91d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/tasks/test_security_helper.rb b/lib/tasks/test_security_helper.rb
@@ -124,6 +124,8 @@ def self.all(format: "human")
     raise SecurityTestFailed unless success
   end
 
+  YARN_AUDIT_SEVERITY_SORT = %w[critical high moderate low info]
+
   def self.rebuild_yarn_audit_pending
     if defined?(ENGINE_ROOT)
       engine_root = ENGINE_ROOT
@@ -164,6 +166,7 @@ def self.rebuild_yarn_audit_pending
         end
 
         values
+        .sort_by { |v| YARN_AUDIT_SEVERITY_SORT.index(v[1]) || Float::MAX }
         .tableize(:header => false)
         .lines
         .map { |l| l.sub(/^ /, "# ") }