Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default views feature #22797

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Remove default views feature #22797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions db/fixtures/miq_product_features.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2828,10 +2828,6 @@
:description: Edit Visuals
:feature_type: admin
:identifier: my_settings_visuals
- :name: Default Views
:description: Edit Default Views
:feature_type: admin
:identifier: my_settings_default_views
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this just works but wanted to ask if there are existing roles with this feature, do they automatically get this removed (and not orphaned). Can you try giving this role to a user role on master, then switch to this branch, seed this fixture via rake db:seed and verify that user role can navigate around without any errors in the related my settings pages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will test it out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it seems to be working. Just tested this out and everything seems to be working fine.

- :name: Default Filters
:description: Edit Default Filters
:feature_type: admin
Expand Down
13 changes: 0 additions & 13 deletions db/fixtures/miq_user_roles.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@
- host_initiator_group
- miq_task_my_ui
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- miq_report_run
Expand Down Expand Up @@ -234,7 +233,6 @@
- host_tag
- host_timeline
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- miq_report_run
Expand Down Expand Up @@ -337,7 +335,6 @@
- host_tag
- miq_task_my_ui
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- miq_report_run
Expand Down Expand Up @@ -423,7 +420,6 @@
- miq_template_show_list
- miq_template_timeline
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- physical_rack
Expand Down Expand Up @@ -531,7 +527,6 @@
- host_tag
- host_timeline
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- miq_report_run
Expand Down Expand Up @@ -627,7 +622,6 @@
- host_tag
- host_timeline
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- miq_report_run
Expand Down Expand Up @@ -714,7 +708,6 @@
- host_timeline
- miq_task_my_ui
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- miq_report_run
Expand Down Expand Up @@ -803,7 +796,6 @@
- host_timeline
- miq_task_my_ui
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- miq_report_run
Expand Down Expand Up @@ -909,7 +901,6 @@
- miq_request_view
- miq_task_my_ui
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- physical_chassis_view
Expand Down Expand Up @@ -966,7 +957,6 @@
- miq_request_view
- miq_task_my_ui
- my_settings_view
- my_settings_default_views
- my_settings_visuals
- service_edit
- service_delete
Expand Down Expand Up @@ -1064,7 +1054,6 @@
- host_initiator_group_edit
- miq_task_my_ui
- my_settings_view
- my_settings_default_views
- my_settings_time_profiles
- my_settings_visuals
- miq_report_run
Expand Down Expand Up @@ -1171,7 +1160,6 @@
- miq_template_tag
- miq_template_timeline
- my_settings_view
- my_settings_default_views
- my_settings_visuals
- miq_request_admin
- miq_request_view
Expand Down Expand Up @@ -1235,7 +1223,6 @@
- miq_template_tag
- miq_template_timeline
- my_settings_view
- my_settings_default_views
- my_settings_visuals
- vm_check_compliance
- vm_clone
Expand Down