Remove default views feature #22797
Remove default views feature #22797
Conversation
GilbertCherrie
force-pushed
the
remove_default_views_feature
branch
from
83ca48c to
48ea349
Compare
| - :name: Default Views | ||
| :description: Edit Default Views | ||
| :feature_type: admin | ||
| :identifier: my_settings_default_views |
There was a problem hiding this comment.
I think this just works but wanted to ask if there are existing roles with this feature, do they automatically get this removed (and not orphaned). Can you try giving this role to a user role on master, then switch to this branch, seed this fixture via rake db:seed and verify that user role can navigate around without any errors in the related my settings pages?
There was a problem hiding this comment.
Yeah I will test it out
There was a problem hiding this comment.
Yeah it seems to be working. Just tested this out and everything seems to be working fine.
GilbertCherrie
force-pushed
the
remove_default_views_feature
branch
from
48ea349 to
b07c9d4
Compare
GilbertCherrie
force-pushed
the
remove_default_views_feature
branch
from
b07c9d4 to
068056b
Compare
|
Checked commit GilbertCherrie@068056b with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
The default views feature is for a deprecated feature and no longer needed after its only reference is being removed in this pr: ManageIQ/manageiq-ui-classic#8965