Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump net-ssh for OpenSSL 3.0 support #244

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Bump net-ssh for OpenSSL 3.0 support #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69f9689
Bump net-ssh for OpenSSL 3.0 support
agrare Apr 16, 2024
6876eaf
Bump required_ruby_version to 2.6
agrare Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jobs:
strategy:
matrix:
ruby-version:
- '2.5'
- '2.6'
- '2.7'
- '3.0'
Expand Down
6 changes: 4 additions & 2 deletions linux_admin.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,19 @@ registration, updates, etc.
spec.executables = `git ls-files -- bin/*`.split("\n")
spec.require_paths = ["lib"]

spec.required_ruby_version = ">= 2.0.0"
spec.required_ruby_version = Gem::Requirement.new(">= 2.6")

spec.add_development_dependency "manageiq-style"
spec.add_development_dependency "rake"
spec.add_development_dependency "rspec", "~> 3.0"
spec.add_development_dependency "rubocop"

spec.add_dependency "awesome_spawn", "~> 1.6"
spec.add_dependency "bcrypt_pbkdf", ">= 1.0", "< 2.0"
spec.add_dependency "ed25519", ">= 1.2", "< 1.3"
spec.add_dependency "inifile"
spec.add_dependency "more_core_extensions", "~> 4.0"
spec.add_dependency "net-ssh", "~> 4.2.0"
spec.add_dependency "net-ssh", "~> 7.2.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdunne Please review - do we know what the follow on effect of this is?
@agrare I'm wondering if we should release this as a major? (at a minimum a minor)

Copy link
Member Author

@agrare agrare Apr 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to drop a supported ruby versions yes this needs to be at least a minor bump, probably a major.
NOTE manageiq has "~>2.0", ">=2.0.1" so if we did v2.1.0 older versions would still pull that in.

Copy link
Member Author

@agrare agrare Apr 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes since 4.2.0:

I don't see any breaking changes listed in the changelog for 6.0.0 but possible there are some

spec.add_dependency "nokogiri", ">= 1.8.5", "!=1.10.0", "!=1.10.1", "!=1.10.2", "<2"
spec.add_dependency "openscap"
spec.add_development_dependency "simplecov", ">= 0.21.2"
Expand Down