Bump net-ssh for OpenSSL 3.0 support #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
It looks like all versions of net-ssh which support openssl 3.0 require ruby >= 2.6 https://github.com/net-ssh/net-ssh/blame/master/net-ssh.gemspec#L18 |
|
Checked commits agrare/linux_admin@69f9689~...6876eaf with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint **
|
Fryguy
reviewed
Apr 16, 2024
| spec.add_dependency "inifile" | ||
| spec.add_dependency "more_core_extensions", "~> 4.0" | ||
| spec.add_dependency "net-ssh", "~> 4.2.0" | ||
| spec.add_dependency "net-ssh", "~> 7.2.3" |
There was a problem hiding this comment.
Since we need to drop a supported ruby versions yes this needs to be at least a minor bump, probably a major.
NOTE manageiq has "~>2.0", ">=2.0.1" so if we did v2.1.0 older versions would still pull that in.
There was a problem hiding this comment.
Breaking changes since 4.2.0:
- https://github.com/net-ssh/net-ssh/blob/master/CHANGES.txt#L127:
Breaking change: ed25519 now requires ed25519 gem instead of RbNaCl gem [#563] - https://github.com/net-ssh/net-ssh/blob/master/CHANGES.txt#L37:
BREAKING: Drop support for Ruby 2.5
I don't see any breaking changes listed in the changelog for 6.0.0 but possible there are some
bdunne
added a commit
that referenced
this pull request
Apr 30, 2024
Breaking Changes: - Bump required_ruby_version to 2.6 & Bump net-ssh for OpenSSL 3.0 support #244 Changed: - Bump ed25519 upper version limit to 2.0 #246 - Bump awesome_spawn minimum to 1.6 #240 - Change redirects to be portable #235 - use PATH to find executable commands #233 Test: - Fix local spec failures on ruby 3.1 #247 - Update paambaati/codeclimate-action action to v6 #245 - Add renovate.json #234 - Update codeclimate channel to the latest in manageiq-style #242 - Test with ruby 3.1 and 3.0 #241 - Fix AwesomeSpawn spec failures #238 - Update actions/checkout version to v4 #237 - Update GitHub Actions versions #236 - update specs to work with recent rspec versions #232 - Add timeout-minutes to setup-ruby job #231 - Switch to GitHub Actions #230 - Remove Hakiri #229 - Fix whitesource config files #228 - Add .whitesource configuration file #227 - Update manageiq-style #226 - drop sudo:false #222 - Switch to manageiq-style #219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add support for
ed25519type ssh keysRelated:
dh#set_pqg= is incompatible with OpenSSL 3.0manageiq-appliance_console#245Required for: ManageIQ/manageiq-appliance_console#248