Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 메서드명 오타 수정과 형식 통일 #140

Merged
merged 4 commits into from
Dec 8, 2023
Merged

refactor: 메서드명 오타 수정과 형식 통일 #140

merged 4 commits into from
Dec 8, 2023

Conversation

shin-mallang
Copy link
Member

@shin-mallang shin-mallang linked an issue Dec 8, 2023 that may be closed by this pull request
[🔥refactor] 메서드명 오타 수정, 형식 통일 #139
Closed
3 tasks
@shin-mallang shin-mallang self-assigned this Dec 8, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Test Results

761 tests  ±0   760 ✔️ ±0   27s ⏱️ -1s
284 suites ±0       1 💤 ±0 
284 files   ±0       0 ❌ ±0 

Results for commit b6a0099. ± Comparison against base commit 8b6ddb5.

This pull request removes 17 and adds 4 tests. Note that renamed tests count towards both. 

 
          Shin._.Mallang
        title-value
    </title>
    <meta property="og:title" content="Shin._.Mallang"/>
    <title>
    HI
 </head>
</body>
…

com.mallang.reference.domain.ReferenceLinkTest$생성_시 ‑ [3] title= 
 
com.mallang.reference.domain.ReferenceLinkTitleTest$생성_시 ‑ [4] title=

com.mallang.reference.infrastructure.jsoup.JsoupUrlTitleMetaInfoFetcherTest ‑ [1] html=<!DOCTYPE html>
<head>
    <title>
          Shin._.Mallang
    </title>
 </head>

<body>
    HI
</body>

</html>

com.mallang.reference.infrastructure.jsoup.JsoupUrlTitleMetaInfoFetcherTest ‑ [2] html=<!DOCTYPE html>
<head>
    <title>
        title-value
    </title>
    <meta property="og:title" content="Shin._.Mallang"/>
 </head>

<body>
    HI
</body>

</html>

@shin-mallang shin-mallang merged commit 9bed700 into main Dec 8, 2023
shin-mallang added a commit that referenced this pull request Dec 10, 2023
@shin-mallang
refactor: 메서드명 오타 수정과 형식 통일 (#140)
f5c8994 
* [#139] refactor: rename validateDependentReference to validateDescendantReference in CategoryValidator

* [#139] refactor: category 주석 수정

* [#139] refactor: Repository 메서드명 형식 통일

* [#139] refactor: polishing post

(cherry picked from commit 9bed700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shin-mallang shin-mallang

Labels
❤️ 사소한 변경
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🔥refactor] 메서드명 오타 수정, 형식 통일
1 participant
@shin-mallang