Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[๐Ÿ”ฅrefactor] ๋ฉ”์„œ๋“œ๋ช… ์˜คํƒ€ ์ˆ˜์ •, ํ˜•์‹ ํ†ต์ผ #139

Closed
3 tasks done
shin-mallang opened this issue Dec 8, 2023 · 0 comments ยท Fixed by #140
Closed
3 tasks done

[๐Ÿ”ฅrefactor] ๋ฉ”์„œ๋“œ๋ช… ์˜คํƒ€ ์ˆ˜์ •, ํ˜•์‹ ํ†ต์ผ #139

shin-mallang opened this issue Dec 8, 2023 · 0 comments ยท Fixed by #140
Labels
๐Ÿš€ ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ

Comments

@shin-mallang
Copy link
Member

shin-mallang commented Dec 8, 2023 •
edited
Loading

โœ… ํ•  ์ผ

  • categoryValidator์˜ dependent -> descendant ๋กœ ๋ณ€๊ฒฝ
  • id๊ฐ€ null์ธ ๊ฒฝ์šฐ null ๋ฐ˜ํ™˜ํ•˜๋Š” ๋ฉ”์„œ๋“œ๋ช… ํ†ต์ผ
  • category ์ฃผ์„ ์˜คํƒ€ ์ˆ˜์ •
@Mallang-log Mallang-log locked and limited conversation to collaborators Dec 8, 2023
@Mallang-log Mallang-log unlocked this conversation Dec 8, 2023
@shin-mallang shin-mallang changed the title [๐Ÿ”ฅrefactor] ๋ฉ”์„œ๋“œ๋ช… ์ˆ˜์ • [๐Ÿ”ฅrefactor] ๋ฉ”์„œ๋“œ๋ช… ์˜คํƒ€ ์ˆ˜์ •, ํ˜•์‹ ํ†ต์ผ Dec 8, 2023
shin-mallang added a commit that referenced this issue Dec 8, 2023
@shin-mallang
[#139] refactor: rename validateDependentReference to validateDescendโ€ฆ
4feab60 
โ€ฆantReference in CategoryValidator
shin-mallang added a commit that referenced this issue Dec 8, 2023
@shin-mallang
[#139] refactor: category ์ฃผ์„ ์ˆ˜์ •
68d6cf8
shin-mallang added a commit that referenced this issue Dec 8, 2023
@shin-mallang
[#139] refactor: Repository ๋ฉ”์„œ๋“œ๋ช… ํ˜•์‹ ํ†ต์ผ
e2ed906
shin-mallang added a commit that referenced this issue Dec 8, 2023
@shin-mallang
[#139] refactor: polishing post
b6a0099
@shin-mallang shin-mallang mentioned this issue Dec 8, 2023
Merged
@shin-mallang shin-mallang linked a pull request Dec 8, 2023 that will close this issue
refactor: ๋ฉ”์„œ๋“œ๋ช… ์˜คํƒ€ ์ˆ˜์ •๊ณผ ํ˜•์‹ ํ†ต์ผ #140
Merged
shin-mallang added a commit that referenced this issue Dec 8, 2023
@shin-mallang
refactor: ๋ฉ”์„œ๋“œ๋ช… ์˜คํƒ€ ์ˆ˜์ •๊ณผ ํ˜•์‹ ํ†ต์ผ (#140)
9bed700 
* [#139] refactor: rename validateDependentReference to validateDescendantReference in CategoryValidator

* [#139] refactor: category ์ฃผ์„ ์ˆ˜์ •

* [#139] refactor: Repository ๋ฉ”์„œ๋“œ๋ช… ํ˜•์‹ ํ†ต์ผ

* [#139] refactor: polishing post
shin-mallang added a commit that referenced this issue Dec 10, 2023
@shin-mallang
refactor: ๋ฉ”์„œ๋“œ๋ช… ์˜คํƒ€ ์ˆ˜์ •๊ณผ ํ˜•์‹ ํ†ต์ผ (#140)
f5c8994 
* [#139] refactor: rename validateDependentReference to validateDescendantReference in CategoryValidator

* [#139] refactor: category ์ฃผ์„ ์ˆ˜์ •

* [#139] refactor: Repository ๋ฉ”์„œ๋“œ๋ช… ํ˜•์‹ ํ†ต์ผ

* [#139] refactor: polishing post

(cherry picked from commit 9bed700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
๐Ÿš€ ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ
Projects
None yet
Milestone
No milestone
1 participant
@shin-mallang