-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Extrapolation #20
Conversation
Ugh, I knew that a python test dependency would be trouble^^
|
Now, this adds a new geometry extrapolation, which adds points from a geometry (right now Rect + Circle), and then uses TopoPlots.jl/src/extrapolation.jl Line 41 in e51420a
I also added some tests for creating those points: I also added new tests to directly compare the output to MNE. |
wow! looks really good. Very impressed about the integration of matplotlib plots... I have a quick question: for me ScatteredInterpolation.jl was super slow (#5). Did you observe the same, or is it negligible because you only interpolate few points? |
@behinger good question... |
function mne_topoplot(fig, data, positions) | ||
circle = TopoPlots.enclosing_geometry(Circle, positions) | ||
# Seems like the only way to plot positions with matching head is to norm the positions.. | ||
# Anything else leads to anarchy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this relate to #18?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question... I don't think it does, but I don't know MNE well enough, to know what's going wrong on there side.
I'll take a look at #18 after this PR!
Co-authored-by: Phillip Alday <[email protected]>
…poPlots.jl into sd/fix-extrapolation
Combine the approaches from #15 #12 and adds comparison tests with PyMNE.
Still needs some clean up of the API and documentation + comments.