-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
padding/enlargement improvements #12
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 90.83% 90.16% -0.67%
==========================================
Files 4 4
Lines 120 122 +2
==========================================
+ Hits 109 110 +1
- Misses 11 12 +1
Continue to review full report at Codecov.
|
|
||
padded_data = lift(pad_data, p.data, npositions, p.pad_value) | ||
|
||
if !isempty(methods(to_value(p.enlarge_value))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calling methods
explicitly is a bit weird. What do you want to do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find out whether elarge_value is a function or not. This is what I googled how to find out whether a variable is callable or not. I guess, one could also check whether it is a Number, and else call the function. probably easier to understand
I don't think there is...If we want to use the mean for extrapolation, we'd need a new PR with a new extrapolator! ;) |
enlarge
Helps to investigate #9, also
padding=0
did not work prior