-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): add textbox component #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 98.23% 98.16% -0.07%
==========================================
Files 55 58 +3
Lines 1074 1198 +124
Branches 107 131 +24
==========================================
+ Hits 1055 1176 +121
- Misses 12 13 +1
- Partials 7 9 +2 ☔ View full report in Codecov by Sentry. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 Scope: Components
Improvements or additions to components
✨ Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the textbox, a component representing an input field for entering/editing
string
values, and the debounced input, a base class for input components with debounced value updates, to the component library.Closes #48
What's been done?
Added the components mentioned above with the following abilities:
TextBox: A component representing an input field for entering/editing
string
valuesInputType.Text
InputVariant.Flat
InputBehavior.OnChange
LabelPlacement.Inside
DebounceInputBase: A base class for input components with debounced value updates
Introduced new enum types to configure textbox's behavior:
InputBehavior: Specifies when the input component updates its value and triggers validation.
InputVariant: Specifies the different variants for an input component.
InputType: Specifies the different types of input elements.
LabelPlacement: Specifies the placement options for the label of an input component.
Checklist