feat(components): add numbox component #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the numbox, a component representing an input field for entering/editing numeric values, and the input field base component, to the component library.
Closes #49
What's been done?
Added the components mentioned above with the following abilities:
InputFieldBase: Represents a base component for form input field components
Basically, it is the Textbox that will now act as a base component for all input field components like textbox, numbox and etc.
The only 2 things I changed are:
Type
parameter is now present only in the textbox to avoid confusionsInputType
enum no longer containsnumber
and all date-related types to avoid confusionsNumbox: A component representing an input field for entering/editing numeric values
Basically, a textbox without the input type control to avoid confusions that:
int
,long
,short
,float
,double
,decimal
Checklist
Notes
Most of the textbox tests should be moved into the
InputFieldBaseTests
.I am kind of lazy about inputs testing. It is just a big frustration for me. I will do them properly later.