Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add numbox component #54

Merged
merged 12 commits into from
Aug 10, 2024
Merged

feat(components): add numbox component #54

merged 12 commits into from
Aug 10, 2024

Conversation

desmondinho
Copy link
Contributor

@desmondinho desmondinho commented Aug 10, 2024

Description

Add the numbox, a component representing an input field for entering/editing numeric values, and the input field base component, to the component library.

Closes #49

What's been done?

Added the components mentioned above with the following abilities:

InputFieldBase: Represents a base component for form input field components

Basically, it is the Textbox that will now act as a base component for all input field components like textbox, numbox and etc.

The only 2 things I changed are:

  1. The Type parameter is now present only in the textbox to avoid confusions
  2. The InputType enum no longer contains number and all date-related types to avoid confusions

Numbox: A component representing an input field for entering/editing numeric values

Basically, a textbox without the input type control to avoid confusions that:

  • Supports int, long, short, float, double, decimal

Checklist

  • My code follows the project's coding style and guidelines.
  • I have included inline docs for my changes, where applicable.
  • I have added, updated or removed tests according to my changes.
  • All tests are passing.
  • There's an open issue for the PR that I am making.

Notes

Most of the textbox tests should be moved into the InputFieldBaseTests.
I am kind of lazy about inputs testing. It is just a big frustration for me. I will do them properly later.

@desmondinho desmondinho added ✨ Type: Enhancement New feature or request 📦 Scope: Components Improvements or additions to components labels Aug 10, 2024
@desmondinho desmondinho self-assigned this Aug 10, 2024
@desmondinho desmondinho linked an issue Aug 10, 2024 that may be closed by this pull request
1 task
@desmondinho desmondinho merged commit fb262f8 into main Aug 10, 2024
1 check passed
@desmondinho desmondinho deleted the dev/numbox branch August 10, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Scope: Components Improvements or additions to components ✨ Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add numbox component
1 participant