Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/scripts/preview-cloudflare.mts
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,14 @@ export async function deletePreviewDeployments(
) {
const branch = await checkPreviewProject(client, number);
const deployments: Deployment[] = [];
// Pages rejects deployment lists larger than 25 with HTTP 400. Use the
// same size to detect the final page when pagination metadata is absent.
const perPage = 25;
// Collect every page before deleting anything. Otherwise deletions shift
// the remaining pages and can leave older PR builds behind.
for (let page = 1; ; page++) {
const response = await client.get<Deployment[]>(
`/deployments?env=preview&per_page=100&page=${page}`,
`/deployments?env=preview&per_page=${perPage}&page=${page}`,
);
deployments.push(
...response.result.filter(
Expand All @@ -108,7 +111,7 @@ export async function deletePreviewDeployments(
if (
totalPages !== undefined
? page >= totalPages
: response.result.length < 100
: response.result.length < perPage
) {
break;
}
Expand Down
64 changes: 64 additions & 0 deletions .github/scripts/preview-cloudflare.test.mts
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,70 @@ test("removes every PR build and its alias without touching other PRs or product
);
});

test("uses supported page sizes and collects every page before deleting", async () => {
for (const includePaginationInfo of [true, false]) {
const deployments = [
deployment("latest", "pr-42"),
...Array.from({ length: 24 }, (_, index) =>
deployment(`other-${index}`, "pr-43"),
),
deployment("old", "pr-42"),
];
const pages: number[] = [];
const deleted: string[] = [];
const client = cloudflareClient(
account,
"lso-previews",
"test-token",
(input, init) => {
const url = new URL(
input instanceof Request ? input.url : input.toString(),
);
let result: unknown = { production_branch: "master" };
let resultInfo: { total_pages: number } | undefined;
if (init?.method === "DELETE") {
assert.deepEqual(pages, [1, 2]);
deleted.push(url.pathname.split("/").at(-1)!);
result = null;
} else if (url.pathname.endsWith("/deployments")) {
const perPage = Number(url.searchParams.get("per_page"));
// Model the endpoint's limit rather than accepting an
// oversized request that Cloudflare rejects with HTTP 400.
if (perPage < 1 || perPage > 25) {
return Promise.resolve(
new Response(null, { status: 400 }),
);
}
const page = Number(url.searchParams.get("page"));
pages.push(page);
result = deployments.slice(
(page - 1) * perPage,
page * perPage,
);
if (includePaginationInfo) {
resultInfo = {
total_pages: Math.ceil(
deployments.length / perPage,
),
};
}
}
return Promise.resolve(
new Response(
JSON.stringify({
success: true,
result,
result_info: resultInfo,
}),
),
);
},
);
assert.equal(await deletePreviewDeployments(client, 42), 2);
assert.deepEqual(deleted, ["latest", "old"]);
}
});

test("empty and already-deleted previews are safe to clean up repeatedly", async () => {
for (const entries of [[], [deployment("gone", "pr-42")]]) {
const client = cloudflareClient(
Expand Down
Loading