Repository navigation
Fix PR Preview Cleanup - #1177
Merged
Merged
Conversation
Cloudflare Pages rejects deployment listings larger than 25 entries with HTTP 400. Cleanup requested 100, so every Remove PR preview run failed before deleting any previews. Request 25 deployments per page and use the same size to detect the last page when Cloudflare omits pagination metadata. Keep collecting every page before deleting deployments so cleanup removes older builds without skipping entries as the list changes. Add a regression case that rejects oversized requests and checks both pagination response forms, with matching PR deployments on separate pages and other PR deployments left untouched.
LiveSplit One preview removedThis PR has closed or merged, so its preview deployments were deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudflare Pages rejects deployment listings larger than 25 entries with HTTP 400. Cleanup requested 100, so every Remove PR preview run failed before deleting any previews.
Request 25 deployments per page and use the same size to detect the last page when Cloudflare omits pagination metadata. Keep collecting every page before deleting deployments so cleanup removes older builds without skipping entries as the list changes.
Add a regression case that rejects oversized requests and checks both pagination response forms, with matching PR deployments on separate pages and other PR deployments left untouched.