Skip to content

Autodoc - #39

Open
jeanjacquemier wants to merge 3 commits into
mainfrom
autodoc
Open

jeanjacquemier wants to merge 3 commits into
mainfrom
autodoc

Conversation

@jeanjacquemier

@jeanjacquemier jeanjacquemier commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Add the documentation with Sphinx and the corresponding mechanisms
- Add a logo to the README
- Add clp_covariance and clp_firecrown confirguration options
- Add an overview
- Add an installation doc:
- Add doc generation with CI
- Use github Pages withgithub actions to publish the docs
- add deployment on autodoc branch before merging
- Add some github badges
- Add LSST DESC software dependencie to doc


deploy:
needs: build
if: github.event_name != 'pull_request' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/autodoc')

@jeanjacquemier jeanjacquemier Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, you can choose when the publication of the document is triggered.

@eduardojsbarroso eduardojsbarroso Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be triggered inside a PR once it is marked READY FOR REVIEW. Also we can add another condition for the deploy which is: it has to eb ready for review and we trigger a button in the github actions, so it is not done all the time:

  deploy:
    needs: build
    if: >
      (github.event_name != 'pull_request' &&
       (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/autodoc'))
      ||
      (github.event_name == 'workflow_dispatch' && inputs.deploy == true)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The documentation contains invalid configuration guidance, lacks functional autodoc, and includes build and deployment defects.

Review effort: Balanced
Findings: 1 High severity · 6 Medium severity · 6 Low severity

Open (13)
What changed in this PR

Introduces a Sphinx documentation site, configuration guides, and automated validation/deployment.

Changes:

  • Adds overview, installation, covariance, and Firecrown documentation.
  • Adds Sphinx configuration and dependencies.
  • Adds documentation CI, GitHub Pages deployment, and README branding.
File Description
README.md Adds the CLPipe logo.
docs/​source/​overview.rst Adds the project overview.
docs/​source/​installation.rst Adds installation and testing instructions.
docs/​source/​clp_firecrown.rst Documents Firecrown configuration.
docs/​source/​clp_covariance.rst Documents covariance configuration.
docs/​requirements.txt Declares documentation dependencies.
docs/​Makefile Adds Sphinx build targets.
docs/​index.rst Defines documentation navigation.
docs/​conf.py Configures Sphinx and its theme.
.gitignore Ignores generated documentation.
.github/​workflows/​docs.yml Builds and deploys documentation.
.github/​workflows/​ci.yml Adds documentation validation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/Makefile Outdated

deploy:
needs: build
if: github.event_name != 'pull_request' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/autodoc')

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, once this doc mechanism will be valided we will remove the autodoc banch

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just not forget to go back to main for publishing the docs before merging this PR

Comment thread docs/Makefile Outdated
Comment thread docs/conf.py Outdated
release = "0.0.1"

root_doc = "index"
extensions = []

@jeanjacquemier jeanjacquemier Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread docs/source/clp_covariance.rst Outdated
Comment on lines +47 to +51
cosmo (str)
Defines how cosmology is provided.

Options:
- "set": use parameters from config

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eduardojsbarroso. Do you confirm ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this was changed. Copilot is right

Comment thread docs/index.rst Outdated
Comment thread docs/source/clp_covariance.rst Outdated
Comment on lines +161 to +162
This is handled by:
extract_data_covariance()

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docs/source/installation.rst Outdated
Comment on lines +13 to +32
```bash
git clone https://github.com/LSSTDESC/CLPipe.git
cd CLPipe
conda env update -f txpipe_environment.yml
conda activate txpipe_clp
pip install .
conda deactivate


conda env update -f firecrown_environment.yml
conda activate firecrown_clp
pip install .
conda env config vars set CSL_DIR=${CONDA_PREFIX}/cosmosis-standard-library
conda deactivate
conda activate firecrown_clp

cd ${CONDA_PREFIX}
source ${CONDA_PREFIX}/bin/cosmosis-configure
cosmosis-build-standard-library main
```
Comment thread docs/source/installation.rst Outdated
Comment on lines +36 to +38
```bash
pytest
```

@jeanjacquemier jeanjacquemier Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread docs/source/overview.rst Outdated
Comment on lines +5 to +8
clpipe is a automated framework developed within the Legacy
Survey of Space and Time Dark Energy Science Collaboration (LSST DESC) for galaxy cluster cos-
mology, in preparation for the first Rubin LSST Data releases. This cluster cosmology pipeline in-
tegrates DESC-developed tools spanning galaxy/cluster catalog ingestion, cluster number count and

@jeanjacquemier jeanjacquemier Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@coveralls

coveralls commented Oct 7, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 37614240398

Warning

No base build found for commit 3a6cd70 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 42.255%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 1020
Covered Lines: 431
Line Coverage: 42.25%
Coverage Strength: 0.85 hits per line

💛 - Coveralls

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

    - Add a logo to the README
    - Add clp_covariance and clp_firecrown confirguration options
    - Add an overview
    - Add an installation doc:
    - Add doc generation with CI
    - Use github Pages withgithub actions to publish the docs
    - add deployment on autodoc branch before merging
    - Add some github badges
    - Add LSST DESC software dependencie to doc
    - Add sphinx copy button extension
    - Add coveralls command
    - Add API doc

on:
push:
branches: [autodoc, main]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to change this to be only main later? Or any PR once ready for review?

This branch was successfully deployed

1 active deployment
github-pages — 838cbe50 Deployed Oct 8, 2026 by eduardojsbarroso via deploy #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants