Repository navigation
Autodoc - #39
Autodoc#39jeanjacquemier wants to merge 3 commits into
Conversation
|
|
||
| deploy: | ||
| needs: build | ||
| if: github.event_name != 'pull_request' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/autodoc') |
There was a problem hiding this comment.
Here, you can choose when the publication of the document is triggered.
There was a problem hiding this comment.
I think this could be triggered inside a PR once it is marked READY FOR REVIEW. Also we can add another condition for the deploy which is: it has to eb ready for review and we trigger a button in the github actions, so it is not done all the time:
deploy:
needs: build
if: >
(github.event_name != 'pull_request' &&
(github.ref == 'refs/heads/main' || github.ref == 'refs/heads/autodoc'))
||
(github.event_name == 'workflow_dispatch' && inputs.deploy == true)
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documentation contains invalid configuration guidance, lacks functional autodoc, and includes build and deployment defects.
Review effort: Balanced
Findings: 1
Open (13)
Keep checked-in documentation out of make clean · New Restrict production publishing to the main branch · New Use O instead of zero for Make options · New Enable autodoc extensions and add API documentation · New Remove unsupported cosmo configuration from CLPCovariance · New Document the correct default HMF model · New Replace copied CLPCovariance options with Firecrown options · New Use descriptive alt text for the logo · New Correct the spelling of publicly · New Reference merge_data_covariance for mixed covariance blocks · New Remove Markdown fences from the reStructuredText literal block · New Remove the literal Markdown fence from the test command · New Fix line wrapping and opening article in overview · New
What changed in this PR
Introduces a Sphinx documentation site, configuration guides, and automated validation/deployment.
Changes:
- Adds overview, installation, covariance, and Firecrown documentation.
- Adds Sphinx configuration and dependencies.
- Adds documentation CI, GitHub Pages deployment, and README branding.
| File | Description |
|---|---|
README.md |
Adds the CLPipe logo. |
docs/source/overview.rst |
Adds the project overview. |
docs/source/installation.rst |
Adds installation and testing instructions. |
docs/source/clp_firecrown.rst |
Documents Firecrown configuration. |
docs/source/clp_covariance.rst |
Documents covariance configuration. |
docs/requirements.txt |
Declares documentation dependencies. |
docs/Makefile |
Adds Sphinx build targets. |
docs/index.rst |
Defines documentation navigation. |
docs/conf.py |
Configures Sphinx and its theme. |
.gitignore |
Ignores generated documentation. |
.github/workflows/docs.yml |
Builds and deploys documentation. |
.github/workflows/ci.yml |
Adds documentation validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| deploy: | ||
| needs: build | ||
| if: github.event_name != 'pull_request' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/autodoc') |
There was a problem hiding this comment.
This is fine for now, once this doc mechanism will be valided we will remove the autodoc banch
There was a problem hiding this comment.
Lets just not forget to go back to main for publishing the docs before merging this PR
| release = "0.0.1" | ||
|
|
||
| root_doc = "index" | ||
| extensions = [] |
| cosmo (str) | ||
| Defines how cosmology is provided. | ||
|
|
||
| Options: | ||
| - "set": use parameters from config |
There was a problem hiding this comment.
Yes this was changed. Copilot is right
| This is handled by: | ||
| extract_data_covariance() |
There was a problem hiding this comment.
| ```bash | ||
| git clone https://github.com/LSSTDESC/CLPipe.git | ||
| cd CLPipe | ||
| conda env update -f txpipe_environment.yml | ||
| conda activate txpipe_clp | ||
| pip install . | ||
| conda deactivate | ||
|
|
||
|
|
||
| conda env update -f firecrown_environment.yml | ||
| conda activate firecrown_clp | ||
| pip install . | ||
| conda env config vars set CSL_DIR=${CONDA_PREFIX}/cosmosis-standard-library | ||
| conda deactivate | ||
| conda activate firecrown_clp | ||
|
|
||
| cd ${CONDA_PREFIX} | ||
| source ${CONDA_PREFIX}/bin/cosmosis-configure | ||
| cosmosis-build-standard-library main | ||
| ``` |
| ```bash | ||
| pytest | ||
| ``` |
| clpipe is a automated framework developed within the Legacy | ||
| Survey of Space and Time Dark Energy Science Collaboration (LSST DESC) for galaxy cluster cos- | ||
| mology, in preparation for the first Rubin LSST Data releases. This cluster cosmology pipeline in- | ||
| tegrates DESC-developed tools spanning galaxy/cluster catalog ingestion, cluster number count and |
7f1ba7f to
e83b2b5
Compare
e83b2b5 to
00ea99c
Compare
00ea99c to
bcec083
Compare
Coverage Report for CI Build 37614240398Warning No base build found for commit Coverage: 42.255%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
2c4550e to
3f1524d
Compare
3f1524d to
306b860
Compare
306b860 to
746e84b
Compare
746e84b to
7adb453
Compare
- Add a logo to the README
- Add clp_covariance and clp_firecrown confirguration options
- Add an overview
- Add an installation doc:
- Add doc generation with CI
- Use github Pages withgithub actions to publish the docs
- add deployment on autodoc branch before merging
- Add some github badges
- Add LSST DESC software dependencie to doc
- Add sphinx copy button extension
- Add coveralls command
- Add API doc
7adb453 to
d9d6132
Compare
|
|
||
| on: | ||
| push: | ||
| branches: [autodoc, main] |
There was a problem hiding this comment.
We have to change this to be only main later? Or any PR once ready for review?



Add the documentation with Sphinx and the corresponding mechanisms
- Add a logo to the README
- Add clp_covariance and clp_firecrown confirguration options
- Add an overview
- Add an installation doc:
- Add doc generation with CI
- Use github Pages withgithub actions to publish the docs
- add deployment on autodoc branch before merging
- Add some github badges
- Add LSST DESC software dependencie to doc