Repository navigation
Update cluster_theory_pred to match CLPFirecrown and add a tutorial - #40
Open
eduardojsbarroso wants to merge 2 commits into
Open
eduardojsbarroso wants to merge 2 commits into
eduardojsbarroso wants to merge 2 commits into
Conversation
…ample - Build the same Firecrown likelihood as the likelihood_file.py written by CLPFirecrown, with the stage defaults taken from CLPFirecrown.config_options - Cosmology from the fiducial cosmology file plus the cosmological_parameters overrides (CosmoSIS names), instead of a hard-coded cosmology - Parameters take the values written in priors_file.ini (starting value when sampled), and can be replaced with params, e.g. a chain best fit - New compute_cluster_predictions returning theory, data, covariance, bins and chi2 - Tests comparing against the likelihood and values files generated by CLPFirecrown
Compares the cosmoDC2 redMaPPer baseline data with the predictions at the starting point and at the best fit of the chain.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clpipe/cluster_theory_pred.pywas out of date withclp_firecrown.pyand the redmapper example. It used a hard-coded cosmology (sampledomega_candsigma_8were silently dropped), different defaults and purity model, and never called the recipe setup. On the redmapper data the counts came out 5 to 10% low.The module now builds the same likelihood as the
likelihood_file.pywritten by CLPFirecrown and evaluates it with Firecrown at one point. The defaults come fromCLPFirecrown.config_optionsand the cosmology from the fiducial cosmology file plus thecosmological_parametersoverrides. Parameters take the values written inpriors_file.ini(starting value when sampled), or the ones passed inparams, for example a chain best fit. Chain column names likecosmological_parameters--omega_calso work.build_cluster_recipes_from_configis kept but now needsfiducial_cosmology=.The new tests compare the predictions with the likelihood and values files generated by CLPFirecrown on the mock SACC. I also checked on CC with
firecrown_developer_clpagainst thelikelihood_file.pyof the redmapper baseline run, and got the same theory vector and chi2 (246.2).The tutorial is in
tutorials/theory_prediction_tutorial. It compares the redmapper baseline data with the predictions at the starting point and at the chain best fit, and shows a quick hmf comparison. It needs the example data from the portal (see README).Two things to keep in mind. There will be a small conflict with #39 in the docstring of
cluster_theory_pred.py, keep this version. Alsouse_grid: falseis not covered by the comparison test yet, becauseclp_firecrown.pyon main does not importExactBinnedClusterRecipe(fixed in #39).