Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ocp version and description to RP import task #68

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Add ocp version and description to RP import task #68

merged 1 commit into from
Mar 11, 2025

Conversation

averevki
Copy link
Contributor

@averevki averevki commented Mar 4, 2025 •
edited
Loading

Add testing cluster version label to imported launch.

Required testsuite changes were in Kuadrant/testsuite#646

@averevki averevki added the enhancement New feature or request label Mar 4, 2025
@averevki averevki self-assigned this Mar 4, 2025
@averevki averevki marked this pull request as ready for review March 10, 2025 16:17
@averevki averevki requested a review from trepel March 10, 2025 16:20
trepel
trepel approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tried but did an eye review and it looks good. I manually tried export OCP_VERSION=$(kubectl get clusterversion -o jsonpath='{.items[].status.history[0].version}') && echo -n ${OCP_VERSION%.*} piece and it worked so this should be good to go.

@averevki averevki merged commit 84e3b6e into Kuadrant:main Mar 11, 2025
2 checks passed
@averevki averevki deleted the rp-import-attributes branch March 11, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trepel trepel trepel approved these changes

Assignees

@averevki averevki

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averevki @trepel