Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MatrixAlgebraKit decompositions #230

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
+371 −45
Draft

[WIP] MatrixAlgebraKit decompositions #230

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a34df99
implement `foreachblock`
lkdvos Mar 16, 2025
2c87848
Implement `eig_full!`
lkdvos Mar 16, 2025
7eab5c1
Use `eig_full` in `eig`
lkdvos Mar 16, 2025
68437b9
Fix factorisation scalartype
lkdvos Mar 19, 2025
5f75ba3
Add scheduler support
lkdvos Mar 19, 2025
f5023f7
Add more convenience constructors to `DiagonalTensorMap`
lkdvos Mar 19, 2025
4bcb517
Add BlockAlgorithm
lkdvos Mar 19, 2025
4326cdb
Add more matrixalgebra methods
lkdvos Mar 19, 2025
fb9fafd
Start switching more factorizations over
lkdvos Mar 20, 2025
ac94a5a
Improve `svd` error messages
lkdvos Mar 20, 2025
cc1953d
more error msg improvements
lkdvos Mar 20, 2025
bb57b79
Properly escape macro hygiene
lkdvos Mar 20, 2025
274aa2d
Fix SVD spaces
lkdvos Mar 20, 2025
40d12d8
Also return `truncerr`
lkdvos Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Fix SVD spaces
@lkdvos
lkdvos committed Mar 20, 2025
commit 274aa2dd7886348e50a40f06adcedae8a4e3220c
8 changes: 4 additions & 4 deletions src/tensors/matrixalgebrakit.jl
View file
Original file line number Diff line number Diff line change
@@ -78,16 +78,16 @@ function MatrixAlgebraKit.initialize_output(::typeof(svd_full!), t::AbstractTens
V_dom = fuse(domain(t))
U = similar(t, domain(t) ← V_cod)
S = similar(t, real(scalartype(t)), V_cod ← V_dom)
Vᴴ = similar(t, domain(t) ← V_dom)
Vᴴ = similar(t, V_dom ← domain(t))
return U, S, Vᴴ
end

function MatrixAlgebraKit.initialize_output(::typeof(svd_compact!), t::AbstractTensorMap,
::MatrixAlgebraKit.AbstractAlgorithm)
V_cod = V_dom = infimum(fuse(codomain(t)), fuse(domain(t)))
U = similar(t, domain(t) ← V_cod)
S = DiagonalTensorMap{real(scalartype(t))}(undef, V_cod ← V_dom)
Vᴴ = similar(t, domain(t) ← V_dom)
U = similar(t, codomain(t) ← V_cod)
S = DiagonalTensorMap{real(scalartype(t))}(undef, V_cod)
Vᴴ = similar(t, V_dom ← domain(t))
return U, S, Vᴴ
end