Skip to content

added: new KalmanCovariance struct to handle covariance sparsity efficiently #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 14, 2025

Conversation

franckgaga
Copy link
Member

@franckgaga franckgaga commented Jun 12, 2025

Similarly to #202 for the objective function weights in MPCs, a new KalmanCovariance parametric struct is created. First, it avoid duplicate code in the constructor of the Kalman filters. Second, two new parameters are introduced to preserve special types like Diagonal{NT, Vector{NT}}. It will also preserves other special types like SparseMatrixCSC. The performance advantages will be mainly visible for the MovingHorizontEstimator with nonlinear plant models, since the objective is computed with e.g. dot(V̂, invR̂_Nk, V̂) and the operation is faster when invR̂_Nk is a Diagonal matrix.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.27027% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.61%. Comparing base (336eaf3) to head (73e36ce).

Files with missing lines Patch % Lines
src/estimator/construct.jl 83.72% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   98.70%   98.61%   -0.09%     
==========================================
  Files          26       26              
  Lines        4308     4327      +19     
==========================================
+ Hits         4252     4267      +15     
- Misses         56       60       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga franckgaga merged commit e7c8c89 into main Jun 14, 2025
4 checks passed
@franckgaga franckgaga deleted the cov_sparsity branch June 14, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants