Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code to align with split-up worklist code & avoid deprecation warnings #54

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Jan 11, 2024

  • 🚚 This moves methods to EvoWorklist which should not have been located in BaseWorklist to begin with.
  • 🚚 Also merges definitions of InvalidOperationError and CompatibilityError into robotools.worklists.exceptions.
  • 🚚 Splits & moves the tests to align with the new structure, and to avoid deprecation warnings.
  • 🛡️ Added tests to cover EvoWorklist.evo_* commands.

Copy link

github-actions bot commented Jan 11, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a4c5dd) 93.04% compared to head (e536428) 95.05%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   93.04%   95.05%   +2.00%     
==========================================
  Files          18       18              
  Lines        1050     1051       +1     
==========================================
+ Hits          977      999      +22     
+ Misses         73       52      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelosthege
Copy link
Member Author

  • The JuBiotech maintainers know my real name.

At least one of the following two applies:

  • The JuBiotech maintainers know my current employer.

  • I am not making this contribution on behalf of my current employer.

@michaelosthege
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA.

@michaelosthege michaelosthege changed the title Move Evo-only commands to EvoWorklist type Move Evo-only commands and exception types Jan 11, 2024
@michaelosthege michaelosthege changed the title Move Evo-only commands and exception types Move code to align with split-up worklist code & avoid deprecation warnings Jan 11, 2024
@michaelosthege michaelosthege self-assigned this Jan 11, 2024
Co-authored-by: Jochen Nießer <[email protected]>
@michaelosthege michaelosthege merged commit 394a740 into master Jan 12, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
@michaelosthege michaelosthege deleted the move-evo-commands branch January 12, 2024 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants