Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test suite to align with new code structure #56

Closed
wants to merge 3 commits into from

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Jan 11, 2024

  • 🚚 This moves methods to EvoWorklist which should not have been located in BaseWorklist to begin with.
  • 🚚 Also merges definitions of InvalidOperationError and CompatibilityError into robotools.worklists.exceptions.
  • 🚚 Splits & moves the tests to align with the new structure, and to avoid deprecation warnings.

@michaelosthege michaelosthege self-assigned this Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (1a4c5dd) 93.04% compared to head (97d2615) 93.05%.
Report is 1 commits behind head on master.

Files Patch % Lines
robotools/evotools/worklist.py 22.22% 21 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   93.04%   93.05%           
=======================================
  Files          18       18           
  Lines        1050     1051    +1     
=======================================
+ Hits          977      978    +1     
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelosthege michaelosthege deleted the refactor-test-suite branch January 11, 2024 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@michaelosthege
Copy link
Member Author

closed in favor of #54

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant