Hid learning wizard gui #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8 already existing)
Don't install ninja on macOS. It is already installed.
improve debug output for missing WWidget pixmaps
fix: disable shallow cloning for sync branch CI
Developer Tools: multi-word search, no Tab navigation in controls table
…ng-2.5 Add Hercules DJControl Inpulse 500 mapping to 2.5
fix js broken by pre-commit
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.1 to 4.6.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.6.1...v4.6.2) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…ns/2.5/actions/upload-artifact-4.6.2 Bump actions/upload-artifact from 4.6.1 to 4.6.2
…ware/mixxxdj/mixxx2-5/. Compile QM files out of TS files that are used by the localized app
because with Qt Creator, the verbose error message for Qt is bypassed.
Fail verbose when Chromaprint is missing
required because VCPKG upstream now used the default meson build system which does not provide cmake config files
# Conflicts: # CMakeLists.txt
…l2FusionStyleImpl
Qt 6.8 ready
Handle new " / " from taglib 2.0
Replaced `getControlValue` with `extractLogicallValue` to improve logical value extraction for both signed and unsigned controls. Updated `setControlValue` to `applyLogicalValue` for better data manipulation and validation. Added comprehensive test cases in `controller_hid_reportdescriptor_test.cpp` to ensure functionality and edge case handling. Included necessary headers and utilized `std::numeric_limits` for robust testing.
- Removed direct use of `m_reportDescriptor` in `ControllerHidReportTabsManager`, utilizing `HidController` for dynamic retrieval. - Added `slotProcessInputReport` to handle incoming reports and update UI tables. - Updated `slotReadReport` and `slotSendReport` to fetch report descriptors from `HidController`. - Modified `HidController` to store report descriptor as `std::optional` for better availability handling. - Enhanced `HidIoThread` to emit `reportReceived` signal with report ID for improved tracking. - Updated `extractLogicallValue` and `applyLogicalValue` functions to include checks for nullable controls. - Overall improvements to code structure, maintainability, and HID report management.
Updated the initialization of `Control` objects in test cases to use nested initializer lists for improved clarity and consistency. Removed the unused `#include <iostream>` directive from `hidreportdescriptor.h`.
- Simplified `createReportTabs` by using `const auto&` for `reportDescriptor`. - Redefined `slotProcessInputReport` to utilize `updateTableWithReportData`. - Added `updateTableWithReportData` for better code organization. - Updated `slotReadReport` to call `updateTableWithReportData`. - Modified `slotSendReport` to use `const auto&` for `reportDescriptor`. - Changed item delegate condition in `populateHidReportTable` to exclude `Input` report type. - Updated class definition to include the new method in the header file.
- Updated `createReportTabs` to adjust button visibility based on report type. - Simplified `updateTableWithReportData` by removing the report parameter. - Modified calls to `updateTableWithReportData` in `slotProcessInputReport` and `slotReadReport` to match the new signature. - Updated method declaration in the header file to align with implementation changes.
- Simplified `createHidReportTabs` method to dynamically create report tabs using an array of report types, reducing code duplication. - Updated `HidReportType` enum with `Q_ENUM_NS` for better Qt integration. - Improved tab naming logic with `QMetaEnum` for enhanced readability. - Added necessary includes and namespace declarations for proper compilation.
Updated method names and tab management in the ControllerHidReportTabsManager class. Renamed createHidReportTabs to createReportTypeTabs and adjusted tab creation logic to use the correct parent tab widget. Modified createHidReportTab to accept parentReportTypeTab and updated tab name formatting to use HTML. Changed visibility checks to reference m_pParentControllerTab. Updated header file and DlgPrefController instantiation accordingly.
…absManager` class to introduce a temporary variable `reportDescriptorTemp`. This variable checks for a valid report descriptor before proceeding, preventing potential null pointer dereference issues. If the report descriptor is not available, the function returns early, enhancing overall code safety.
JoergAtGithub
force-pushed
the
hid_learning_wizard_gui
branch
from
b0e65b4 to
fb31ea6
Compare
|
This PR is marked as stale because it has been open 90 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.