Refactor the createHidReportTab method in the ControllerHidReportTabsManager class to introduce a temporary variable reportDescriptorTemp. This variable checks for a valid report descriptor before proceeding, preventing potential null pointer dereference issues. If the report descriptor is not available, the function returns early, enhancing overall code safety.

Author: JoergAtGithub

src/controllers/controllerhidreporttabsmanager.cpp

@@ -38,7 +38,11 @@ void ControllerHidReportTabsManager::createReportTypeTabs() {
 
 void ControllerHidReportTabsManager::createHidReportTab(QTabWidget* parentReportTypeTab,
         hid::reportDescriptor::HidReportType reportType) {
-    const auto& reportDescriptor = *m_pHidController->getReportDescriptor();
+    const auto& reportDescriptorTemp = m_pHidController->getReportDescriptor();
+    if (!reportDescriptorTemp.has_value()) {
+        return;
+    }
+    const auto& reportDescriptor = *reportDescriptorTemp;
 
     QMetaEnum metaEnum = QMetaEnum::fromType<hid::reportDescriptor::HidReportType>();