[김진명 - 1 단계] PR #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-so
reviewed
Mar 19, 2025
There was a problem hiding this comment.
@makeUgreat
step1 과제하느라 수고하셨습니다! PR 브랜치를 개인 깃허브 명으로 변경 후, 개인 브랜치에 PR 재작업 부탁드리겠습니다! 코멘트 달아두었으니 확인 부탁드리겠습니담!
- 커밋 단위는 개개인마다 파일별로 작성할지, 기능별로 작성하는지 다른 것 같아요! 개인적으로 파일별 수정이 있을때마다 커밋 시 너무 짧게 가져가는 느낌이 있어 기능별로 커밋 단위로 가져가고 있습니다!
- PR 메시지의 경우 다음의 git 컨벤션을 참고하셔서 작업하시면 좋을 것 같습니다!
PR 커밋 메시지 예시 1
PR 커밋 메시지 예시 2
| #answer; | ||
|
|
||
| constructor() { | ||
| this.#answer = MissionUtils.Random.pickNumberInRange(100,999); |
There was a problem hiding this comment.
p1 : 과제 요구사항에서 1~9까지 서로 다른 수로 이어진 3자리 숫자를 생성하도록 명시되어 있어요!
pickNumberInRange메소드 사용할 때 mission-utils 라이브러리 사용할 때 확인 부탁드리겠습니다!
mission-utils 라이브러리
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
RandomNumber객체를 만들도록 하였습니다.👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점