feat: respect BE network body limit #593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `onNetworkLogBodyMaxSizeChange` method to `FeatureFlagsFlutterApi` in Dart. - Implemented `getNetworkBodyMaxSize` method in `InstabugApi` to retrieve network log character limit. - Updated `InstabugApiTest` with a new test for `getNetworkBodyMaxSize`.
- Updated Instabug podspec to version 15.0.1. - Added `getNetworkBodyMaxSize` method in `InstabugApi` for retrieving network log body size. - Introduced a new test case for `getNetworkBodyMaxSize` in `InstabugApiTests`. - Updated .gitignore files to include project-specific and Android-related paths.
… in feature flags manager - Added `_networkBodyMaxSize` to `FeatureFlagsManager` for managing network body size limits. - Introduced `didRequestBodyExceedSizeLimit` and `didResponseBodyExceedSizeLimit` methods in `NetworkManager` to validate request and response body sizes against the limit. - Created `InstabugConstants` for standardized logging messages related to network body size limits. - Implemented caching for network body size retrieval to optimize performance.
…r.dart` - Added early checks for request and response body size limits in `networkLogInternal`. - Implemented truncation of request/response bodies with warning messages if size limits are exceeded. - Logged truncation events using `InstabugLogger` for better visibility into network logging behavior.
… specific tests - Introduced a default network body max size of 10KB to improve logging consistency. - Updated error handling to set the cached size to the default when native API retrieval fails. - Added unit tests for `didRequestBodyExceedSizeLimit` and `didResponseBodyExceedSizeLimit` to ensure proper size limit checks for request and response bodies.
- Changed the return type of `getNetworkBodyMaxSize` from `int?` to `double?` in the API and updated related method calls accordingly. - Renamed `registerW3CFlagsListener` to `registerFeatureFlagsListener` for consistency across the codebase. - Introduced a callback mechanism in `FeatureFlagsManager` to handle changes in network body max size, ensuring proper cache management in `NetworkManager`. - Updated tests to reflect the new method names and ensure functionality remains intact.
MoKamall
force-pushed
the
feat/respect-BE-network-body-limit
branch
from
ae699ad to
fa2279f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review