Skip to content

Commit ae699ad

Browse files
committed
fix: improve formatting to align with linter
1 parent 2b72395 commit ae699ad

File tree

4 files changed

+44
-27
lines changed

4 files changed

+44
-27
lines changed

lib/src/modules/network_logger.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,13 @@ class NetworkLogger {
9999
processedData = data.copyWith(
100100
requestBody: requestExceeds
101101
? InstabugConstants.getRequestBodyReplacementMessage(
102-
data.requestBodySize)
102+
data.requestBodySize,
103+
)
103104
: data.requestBody,
104105
responseBody: responseExceeds
105106
? InstabugConstants.getResponseBodyReplacementMessage(
106-
data.responseBodySize)
107+
data.responseBodySize,
108+
)
107109
: data.responseBody,
108110
);
109111

lib/src/utils/feature_flags_manager.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ class FeatureFlagsManager implements FeatureFlagsFlutterApi {
4747
/// Sets the callback for network body max size changes
4848
// ignore: avoid_setters_without_getters
4949
set onNetworkBodyMaxSizeChangeCallback(
50-
OnNetworkBodyMaxSizeChangeCallback callback) {
50+
OnNetworkBodyMaxSizeChangeCallback callback,
51+
) {
5152
_onNetworkBodyMaxSizeChangeCallback = callback;
5253
}
5354

lib/src/utils/network_manager.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class NetworkManager {
1515
ObfuscateLogCallback? _obfuscateLogCallback;
1616
OmitLogCallback? _omitLogCallback;
1717
int? _cachedNetworkBodyMaxSize;
18-
int _defaultNetworkBodyMaxSize = 10240; // in bytes
18+
final int _defaultNetworkBodyMaxSize = 10240; // in bytes
1919
final _host = InstabugHostApi();
2020

2121
NetworkManager() {
@@ -116,22 +116,19 @@ class NetworkManager {
116116
/// Gets the network body max size from native SDK, with caching
117117
Future<int?> _getNetworkBodyMaxSize() async {
118118
if (_cachedNetworkBodyMaxSize != null) {
119-
print('[Kamal] _cachedNetworkBodyMaxSize: $_cachedNetworkBodyMaxSize');
120119
return _cachedNetworkBodyMaxSize;
121120
}
122121

123122
final ffmNetworkBodyLimit = FeatureFlagsManager().networkBodyMaxSize;
124123

125124
if (ffmNetworkBodyLimit > 0) {
126125
_cachedNetworkBodyMaxSize = ffmNetworkBodyLimit;
127-
print('[Kamal] ffmNetworkBodyLimit: $ffmNetworkBodyLimit');
128126
return ffmNetworkBodyLimit;
129127
}
130128

131129
try {
132130
final limit = await _host.getNetworkBodyMaxSize();
133131
_cachedNetworkBodyMaxSize = limit?.toInt();
134-
print('[Kamal] limit: $limit');
135132
return limit?.toInt();
136133
} catch (error) {
137134
InstabugLogger.I.e(
@@ -141,7 +138,6 @@ class NetworkManager {
141138
tag: InstabugConstants.networkManagerTag,
142139
);
143140
_cachedNetworkBodyMaxSize = _defaultNetworkBodyMaxSize;
144-
print('[Kamal] _defaultNetworkBodyMaxSize: $_defaultNetworkBodyMaxSize');
145141
return _defaultNetworkBodyMaxSize;
146142
}
147143
}

test/network_logger_test.dart

Lines changed: 37 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -265,12 +265,18 @@ void main() {
265265
await logger.networkLogInternal(largeRequestData);
266266

267267
// Verify that obfuscateLog was called with modified data
268-
verify(mManager.obfuscateLog(argThat(
269-
predicate<NetworkData>((processedData) =>
270-
processedData.requestBody ==
271-
'[REQUEST_BODY_REPLACED] - Size: 15000 exceeds limit' &&
272-
processedData.responseBody == largeRequestData.responseBody),
273-
))).called(1);
268+
verify(
269+
mManager.obfuscateLog(
270+
argThat(
271+
predicate<NetworkData>(
272+
(processedData) =>
273+
processedData.requestBody ==
274+
'[REQUEST_BODY_REPLACED] - Size: 15000 exceeds limit' &&
275+
processedData.responseBody == largeRequestData.responseBody,
276+
),
277+
),
278+
),
279+
).called(1);
274280

275281
// Verify that networkLog was called
276282
verify(mInstabugHost.networkLog(any)).called(1);
@@ -297,12 +303,18 @@ void main() {
297303
await logger.networkLogInternal(largeResponseData);
298304

299305
// Verify that obfuscateLog was called with modified data
300-
verify(mManager.obfuscateLog(argThat(
301-
predicate<NetworkData>((processedData) =>
302-
processedData.requestBody == largeResponseData.requestBody &&
303-
processedData.responseBody ==
304-
'[RESPONSE_BODY_REPLACED] - Size: 15000 exceeds limit'),
305-
))).called(1);
306+
verify(
307+
mManager.obfuscateLog(
308+
argThat(
309+
predicate<NetworkData>(
310+
(processedData) =>
311+
processedData.requestBody == largeResponseData.requestBody &&
312+
processedData.responseBody ==
313+
'[RESPONSE_BODY_REPLACED] - Size: 15000 exceeds limit',
314+
),
315+
),
316+
),
317+
).called(1);
306318

307319
// Verify that networkLog was called
308320
verify(mInstabugHost.networkLog(any)).called(1);
@@ -329,13 +341,19 @@ void main() {
329341
await logger.networkLogInternal(largeBothData);
330342

331343
// Verify that obfuscateLog was called with modified data
332-
verify(mManager.obfuscateLog(argThat(
333-
predicate<NetworkData>((processedData) =>
334-
processedData.requestBody ==
335-
'[REQUEST_BODY_REPLACED] - Size: 15000 exceeds limit' &&
336-
processedData.responseBody ==
337-
'[RESPONSE_BODY_REPLACED] - Size: 15000 exceeds limit'),
338-
))).called(1);
344+
verify(
345+
mManager.obfuscateLog(
346+
argThat(
347+
predicate<NetworkData>(
348+
(processedData) =>
349+
processedData.requestBody ==
350+
'[REQUEST_BODY_REPLACED] - Size: 15000 exceeds limit' &&
351+
processedData.responseBody ==
352+
'[RESPONSE_BODY_REPLACED] - Size: 15000 exceeds limit',
353+
),
354+
),
355+
),
356+
).called(1);
339357

340358
// Verify that networkLog was called
341359
verify(mInstabugHost.networkLog(any)).called(1);

0 commit comments

Comments
 (0)