Skip to content

STYLE: Remove Image and OffsetTable from ImageConstIteratorWithOnlyIndex #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewtex merged 1 commit into from
Feb 23, 2026
+3 −9
Merged

STYLE: Remove Image and OffsetTable from ImageConstIteratorWithOnlyIndex #5813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Modules/Core/Common/include/itkImageConstIteratorWithOnlyIndex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,7 @@ class ITK_TEMPLATE_EXPORT ImageConstIteratorWithOnlyIndex
return m_Remaining;
}

protected: // made protected so other iterators can access
typename TImage::ConstPointer m_Image{};

protected: // made protected so other iterators can access
IndexType m_PositionIndex{ { 0 } }; // Index where we currently are
IndexType m_BeginIndex{ { 0 } }; // Index to start iterating over
IndexType m_EndIndex{ { 0 } }; // Index to finish iterating:
Expand All @@ -257,8 +255,6 @@ class ITK_TEMPLATE_EXPORT ImageConstIteratorWithOnlyIndex

RegionType m_Region{}; // region to iterate over

OffsetValueType m_OffsetTable[ImageDimension + 1]{};

bool m_Remaining{ false };
};
} // end namespace itk
Expand Down
6 changes: 2 additions & 4 deletions Modules/Core/Common/include/itkImageConstIteratorWithOnlyIndex.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,11 @@ namespace itk
// Constructor
//----------------------------------------------------------------------
template <typename TImage>
ImageConstIteratorWithOnlyIndex<TImage>::ImageConstIteratorWithOnlyIndex(const TImage * ptr, const RegionType & region)
: m_Image(ptr)
, m_BeginIndex(region.GetIndex())
ImageConstIteratorWithOnlyIndex<TImage>::ImageConstIteratorWithOnlyIndex(const TImage *, const RegionType & region)
: m_BeginIndex(region.GetIndex())
, m_Region(region)
{
m_PositionIndex = m_BeginIndex;
std::copy_n(m_Image->GetOffsetTable(), ImageDimension + 1, m_OffsetTable);

// Compute the end offset
for (unsigned int i = 0; i < ImageDimension; ++i)
Expand Down
Loading