STYLE: Remove Image and OffsetTable from ImageConstIteratorWithOnlyIndex#5813
Open
N-Dekker wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
Iterators "with only index" do not need to have access to the image or its offset table.
github-actions
bot
added
area:Core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterators "with only index" do not need to have access to the image or its offset table.
It appears that those apparently unnecessary data members were there already with the initial commit, ENH: Add "WithOnlyIndex" iterators., Michael Stauffer (@mgstauffer), 14 years ago:
ITK/Modules/Core/Common/include/itkImageConstIteratorWithOnlyIndex.h
Line 262 in 8703c0a
ITK/Modules/Core/Common/include/itkImageConstIteratorWithOnlyIndex.h
Line 272 in 8703c0a
@mgstauffer Do you possibly still have a clue why
ImageConstIteratorWithOnlyIndexhas those two data members? Do you agree that they appear unnecessary?