Skip to content

Bugfix timer stopping buzzing when 10 seconds haven't passed #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thulium-Drake wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix timer stopping buzzing when 10 seconds haven't passed #2428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/displayapp/screens/Timer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ void Timer::Refresh() {
// Timer exists and has expired, so we're in ringing mode
DisplayTime();

if (timerStatus->distanceToExpiry.count() < 10000 && !motorController.IsRinging()) {
// If 10 seconds haven't passed and we're not buzzing, keep buzzing
motorController.StartRinging();
}

if (timerStatus->distanceToExpiry.count() > 10000 && motorController.IsRinging()) {
// Stop buzzing after 10 seconds, but continue the counter
motorController.StopRinging();
Expand Down
Loading