Bugfix timer stopping buzzing when 10 seconds haven't passed#2428
Open
Thulium-Drake wants to merge 1 commit intoInfiniTimeOrg:mainfrom
Open
Bugfix timer stopping buzzing when 10 seconds haven't passed#2428Thulium-Drake wants to merge 1 commit intoInfiniTimeOrg:mainfrom
Thulium-Drake wants to merge 1 commit intoInfiniTimeOrg:mainfrom
Conversation
|
Build size and comparison to main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
Another thing my GF noticed when using the timer app, it buzzes twice and then stops buzzing. And I've seen a lot of issues, PRs etc mentioning this (#2085 #391 and some others). But I when went looking in the source specifically because #1971 mentions it changed that the watch should keep buzzing for 10 seconds, but my tests in InfiniSim (as well as the experience from my GF) is that it buzzes twice and then stops.
So I have patched the logic to keep buzzing when it isn't buzzing already for 10 seconds.
NOTE: This does not fix the "receiving notifications cancels the timer" bug, as that event will cause the Timer app to exit, killing the buzz (literally ;-) )