-
Notifications
You must be signed in to change notification settings - Fork 6
V19 updates #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vnext
Are you sure you want to change the base?
V19 updates #751
Conversation
@damyanpetev |
@mddifilippo89 Um, nether actually, I think :) There's a patch update underway and while this is the v19 update feature branch, currently it only contains the package update and none of the actual changes required (like #752, #753, #754 and more inc) to stabilize it. So it's not ready just yet, thus the Draft status. As we discussed, I believe I've updated all samples, including the ones in your PR, so this should already contain most/all of your changes. You can try to re-target your PR to this branch to verify. |
Grids update remove name prop
…overs refactor: manual grid samples enum casing
Grids and inputs event on- prefix
…s an idiot with nested deps
…mes-p2 refactor: manual samples rename change to onChange, adjust handlers
State based on #749, will switch to vnext target once that's merged.Generated package updates from IgniteUI/igniteui-xplat-examples#830:
igniteui-react-grids
andigniteui-react
Breaking changes:This release include a major rework of some of our React components internals leading to the following changes:
ref
s obtained from a component will be a forward of the native element instead of a class component instance. Since those are custom elements with mostly the same component-specific API, in addition to the DOM APIs without the need to additionally access native element, that means many of the uses could remain unchanged but there are possible changes required - such as not needing an extra property to access the DOM element.boolean | string
ornumber | string
). Additionally, string union types (enum-like) are no longer case-insensitive.name
prop by default. Thename
prop only remains inigniteui-react
components, mostly form inputs such asIgrInput
orIgrCombo
, where it has native functionality.on-
prefixed.For example, Grid's
rendered={handler}
becomesonRendered={handler}
CustomEvent
argument instead of the 'sender' as first argument. Therefore, custom props likeargs.nativeElement
are no longer available, but native event props all are. Types for event args are available as aliases for the specific custom event, so usage accessingdetail
will remain much the same:For example:
public handleChange(sender: IgrRadio, evt: IgrRadioChangeEventArgs) { }
becomes:
public handleChange(evt: IgrRadioChangeEventArgs) { }
which is equivalent topublic handleChange(evt: CustomEvent<IgrRadioChangeEventArgsDetail>) { }
With the new handler signature
evt.detail
should be mostly the same andevt.target
should is the DOM element equivalent of the sender.clicked
is removed, use the nativeonClick
instead.inputOcurred
is renamed toonInput
similar to native event.