Favorites feature #125
Open
Favorites feature #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrauh01
force-pushed
the
favorites-new
branch
4 times, most recently
from
3de000a to
593900d
Compare
When inserting a new favorite, the new favorite gets the priority + 1 of the favorite with the currently highest priority. If no favorite is stored for the kind the new favorite gets the priority 0. When deleting a favorite, all favorites with higher priority are decremented by 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the first implementation of the feature in #117.
It introduces the ability to mark resources as favorites. Thus a quick action is added to the resource's detail view, allowing users to favor or unfavor resources. To show the favorites there is a toggle in the controls section above the action list. If the toggle is active in the dropdown menu to choose to sort by what there is a new 'Custom Order' option. If the list is sorted by 'Custom Order' the user can reorder the favorites via drag & drop. Favorites are stored per user. Additionally to resource uuid and username, the resource's kind is stored to optimize database queries.
There is also a dashboard to show all favorites of all resources summarized.
Closes #107