Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep h1 titles on favorite dashboard #5331

Closed
wants to merge 1 commit into from

Conversation

jrauh01
Copy link

@jrauh01 jrauh01 commented Mar 5, 2025

Add JavaScript to keep h1 titles, when the content is rendered to the containers on the favorite dashboard of Icinga for Kubernetes.

Refs Favorite feature of Icinga for Kubernetes

@cla-bot cla-bot bot added the cla/signed label Mar 5, 2025
@jrauh01 jrauh01 requested a review from lippserd March 5, 2025 09:04
@nilmerg
Copy link
Member

nilmerg commented Mar 6, 2025

I have strong objections against this. Is it an option to not place the h1 tag inside the refreshing container?

@jrauh01
Copy link
Author

jrauh01 commented Mar 10, 2025

Yes, solved it placing the h1 tag outside the container!

@jrauh01 jrauh01 closed this Mar 10, 2025
@jrauh01 jrauh01 deleted the kubernetes-favorite-dashboard branch March 10, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants